linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block/partitions/efi.c: Fix the efi_partition() kernel-doc header
@ 2021-05-12 20:17 Bart Van Assche
  2021-05-12 21:18 ` Jens Axboe
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2021-05-12 20:17 UTC (permalink / raw)
  To: Jens Axboe
  Cc: linux-block, Christoph Hellwig, Bart Van Assche, Alexander Viro

Fix the following kernel-doc warning:

block/partitions/efi.c:685: warning: wrong kernel-doc identifier on line:
 * efi_partition(struct parsed_partitions *state)

Cc: Alexander Viro <viro@math.psu.edu>
Fixes: a22f8253014b ("[PATCH] partition parsing cleanup")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/partitions/efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partitions/efi.c b/block/partitions/efi.c
index b64bfdd4326c..e2716792ecc1 100644
--- a/block/partitions/efi.c
+++ b/block/partitions/efi.c
@@ -682,7 +682,7 @@ static void utf16_le_to_7bit(const __le16 *in, unsigned int size, u8 *out)
 }
 
 /**
- * efi_partition(struct parsed_partitions *state)
+ * efi_partition - scan for GPT partitions
  * @state: disk parsed partitions
  *
  * Description: called from check.c, if the disk contains GPT

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block/partitions/efi.c: Fix the efi_partition() kernel-doc header
  2021-05-12 20:17 [PATCH] block/partitions/efi.c: Fix the efi_partition() kernel-doc header Bart Van Assche
@ 2021-05-12 21:18 ` Jens Axboe
  2021-05-12 22:23   ` Bart Van Assche
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2021-05-12 21:18 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: linux-block, Christoph Hellwig, Alexander Viro

On 5/12/21 2:17 PM, Bart Van Assche wrote:
> Fix the following kernel-doc warning:
> 
> block/partitions/efi.c:685: warning: wrong kernel-doc identifier on line:
>  * efi_partition(struct parsed_partitions *state)
> 
> Cc: Alexander Viro <viro@math.psu.edu>
> Fixes: a22f8253014b ("[PATCH] partition parsing cleanup")

Heh, I think using a sha from the history tree might cause more
harm than good. If you want it applied to any stable, probably
better to just use:

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block/partitions/efi.c: Fix the efi_partition() kernel-doc header
  2021-05-12 21:18 ` Jens Axboe
@ 2021-05-12 22:23   ` Bart Van Assche
  0 siblings, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2021-05-12 22:23 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-block, Christoph Hellwig, Alexander Viro

On 5/12/21 2:18 PM, Jens Axboe wrote:
> On 5/12/21 2:17 PM, Bart Van Assche wrote:
>> Fix the following kernel-doc warning:
>>
>> block/partitions/efi.c:685: warning: wrong kernel-doc identifier on line:
>>   * efi_partition(struct parsed_partitions *state)
>>
>> Cc: Alexander Viro <viro@math.psu.edu>
>> Fixes: a22f8253014b ("[PATCH] partition parsing cleanup")
> 
> Heh, I think using a sha from the history tree might cause more
> harm than good. If you want it applied to any stable, probably
> better to just use:
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

You are right, but it is not my intention to send this patch to any 
stable tree. I'm fine with leaving out the Fixes: tag. If it would be 
inconvenient for you to do this then I will repost this patch.

Thanks,

Bart.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-12 22:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 20:17 [PATCH] block/partitions/efi.c: Fix the efi_partition() kernel-doc header Bart Van Assche
2021-05-12 21:18 ` Jens Axboe
2021-05-12 22:23   ` Bart Van Assche

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).