From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38715C433DF for ; Fri, 22 May 2020 09:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E3A4207FB for ; Fri, 22 May 2020 09:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728424AbgEVJNo (ORCPT ); Fri, 22 May 2020 05:13:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:47426 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728368AbgEVJNo (ORCPT ); Fri, 22 May 2020 05:13:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 72535B2038; Fri, 22 May 2020 09:13:45 +0000 (UTC) Subject: Re: [PATCH 2/6] blk-mq: simplify the blk_mq_get_request calling convention To: Christoph Hellwig Cc: linux-block@vger.kernel.org, John Garry , Bart Van Assche , Hannes Reinecke , Thomas Gleixner References: <20200520170635.2094101-1-hch@lst.de> <20200520170635.2094101-3-hch@lst.de> From: Hannes Reinecke Message-ID: <6d356a18-a104-323b-34c0-ed69929fa986@suse.de> Date: Fri, 22 May 2020 11:13:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200520170635.2094101-3-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/20/20 7:06 PM, Christoph Hellwig wrote: > The bio argument is entirely unused, and the request_queue can be passed > through the alloc_data, given that it needs to be filled out for the > low-level tag allocation anyway. Also rename the function to > __blk_mq_alloc_request as the switch between get and alloc in the call > chains is rather confusing. > > Signed-off-by: Christoph Hellwig > --- > block/blk-mq.c | 36 ++++++++++++++++++++++-------------- > 1 file changed, 22 insertions(+), 14 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer