From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93894C43603 for ; Thu, 12 Dec 2019 16:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68F2D22527 for ; Thu, 12 Dec 2019 16:35:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="xbcplkXM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729941AbfLLQf0 (ORCPT ); Thu, 12 Dec 2019 11:35:26 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:42925 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729913AbfLLQf0 (ORCPT ); Thu, 12 Dec 2019 11:35:26 -0500 Received: by mail-il1-f194.google.com with SMTP id a6so84517ili.9 for ; Thu, 12 Dec 2019 08:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3FtLIVj+wnM2ARUnkHjLCIs+M1M/IA6PpWp8jtXGxBs=; b=xbcplkXMsLKBVhI2XoEAIhOCDrqD47HX6n1yvO5V22GmwrrQQBKbWggYHs4jvP1r5e d06kkPEOnjJE94l1i8s0OQBGyq2uCnz06HSXakJyefIeamZrYC04IsPHZG0q8AamKYX7 hQiBFF2unkfh+vzBU4sfnsk8eFSJqiqGb27+ELN3raRO+1VzqxuUmJvQteWCoq4j74gw zDZjlxcYlLJc7nj02zY/1J5oio91PD6bX3m6ftojddzXMI4lyWGMcOBLF2IgQDl1+DS4 M8/9vHNTZSCqOo/1DexoCnH9ZtJ4bViECOh2oT+MHZ1qxnhhm7JEOSFNx7VJQCROP4qJ 4jQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3FtLIVj+wnM2ARUnkHjLCIs+M1M/IA6PpWp8jtXGxBs=; b=P5xih6ZHoB9RY6ZYqqBL8BJuO/MmoG7F0EX2CDzrvysxIp2Vv933uTmrC4fsAD4byZ Imd86ghkp0Dls/q/vrOaQkBtqEjKOvovpqStvIvUCDEHg7cRAO71W4MfyIcV2sNlqPaq Ywrq4tiZAzxPQIF5IWDq1u9yJo0KFIWpYpSdAspuSl1iI7wSO78ULS0ZwFMi4EID/WLL KHeUb2XLF4cOR5jIW03bc5WSOJihxO/E3PAnA3flrITmonPT8xhIzkFusmISh8P4vPtU /Dkh7ecTMqaVxXUgQCWFGifc93CHHiTJ05KJTiVg4NV47zgR3AZV9YE8QTaTzMFhnj/r UPfA== X-Gm-Message-State: APjAAAVxhGdW3QkaRMbNqoZv4A04kXsby1QhP06qA30r9FWmwjR1teDw W1euUurfiUCsYSbtHHp2sd5e9Q== X-Google-Smtp-Source: APXvYqxAPt9ybQh/T8WYBX6qxbHJzz4zpYaVA1B8qE0Zhi2chspe24qfeJl3SeUOs00SEoxpnZbeng== X-Received: by 2002:a92:5d03:: with SMTP id r3mr8554165ilb.278.1576168525332; Thu, 12 Dec 2019 08:35:25 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id x62sm1843784ill.86.2019.12.12.08.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 08:35:24 -0800 (PST) Subject: Re: [PATCH 15/24] compat_ioctl: scsi: move ioctl handling into drivers To: Christoph Hellwig , Paolo Bonzini Cc: "Michael S. Tsirkin" , Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Jason Wang , Doug Gilbert , =?UTF-8?Q?Kai_M=c3=a4kisara?= , linux-kernel@vger.kernel.org, y2038@lists.linaro.org, Stefan Hajnoczi , Bart Van Assche , Hannes Reinecke , Damien Le Moal , John Garry , virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20191211204306.1207817-1-arnd@arndb.de> <20191211204306.1207817-16-arnd@arndb.de> <20191211180155-mutt-send-email-mst@kernel.org> <858768fb-5f79-8259-eb6a-a26f18fb0e04@redhat.com> <20191212162729.GB27991@infradead.org> From: Jens Axboe Message-ID: <6e265890-23e5-6368-4e36-d59ff47879b2@kernel.dk> Date: Thu, 12 Dec 2019 09:35:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191212162729.GB27991@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 12/12/19 9:27 AM, Christoph Hellwig wrote: > On Thu, Dec 12, 2019 at 01:28:08AM +0100, Paolo Bonzini wrote: >> I think it's because the only ioctl for virtio-blk is SG_IO. It makes >> sense to lump it in with scsi, but I wouldn't mind getting rid of >> CONFIG_VIRTIO_BLK_SCSI altogether. > > CONFIG_VIRTIO_BLK_SCSI has been broken for about two years, as it > never set the QUEUE_FLAG_SCSI_PASSTHROUGH flag after that was > introduced. I actually have a patch that I plan to send to remove > this support as it was a really idea to start with (speaking as > the person who had that idea back in the day). We had this very discussion two years ago, and we never got it removed. Let's please get it done. -- Jens Axboe