From: Jens Axboe <axboe@kernel.dk>
To: yangerkun <yangerkun@huawei.com>, hristo@venev.name
Cc: linux-block@vger.kernel.org, yi.zhang@huawei.com, houtao1@huawei.com
Subject: Re: [PATCH] io_uring: compare cached_cq_tail with cq.head in_io_uring_poll
Date: Tue, 24 Sep 2019 15:22:10 +0200 [thread overview]
Message-ID: <6e32a5b7-2782-69e8-b4e4-8574d910d517@kernel.dk> (raw)
In-Reply-To: <20190924125334.5543-1-yangerkun@huawei.com>
On 9/24/19 6:53 AM, yangerkun wrote:
> After 75b28af("io_uring: allocate the two rings together"), we compare
> sq.head with cached_cq_tail to determine does there any cq invalid.
> Actually, we should use cq.head.
Nice catch, applied. BTW, note for future submissions, this:
> Fixes: 75b28af ("io_uring: allocate the two rings together")
sha should be 12 characters. I will fix it up in this one.
--
Jens Axboe
prev parent reply other threads:[~2019-09-24 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 12:53 [PATCH] io_uring: compare cached_cq_tail with cq.head in_io_uring_poll yangerkun
2019-09-24 13:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e32a5b7-2782-69e8-b4e4-8574d910d517@kernel.dk \
--to=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=hristo@venev.name \
--cc=linux-block@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).