linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 1/8] loop: use sysfs_emit() in the sysfs offset show
Date: Tue, 21 Sep 2021 13:33:47 +0000	[thread overview]
Message-ID: <759AF0F5-B424-4F96-800A-45E8DF944296@oracle.com> (raw)
In-Reply-To: <20210921092123.13632-2-chaitanyak@nvidia.com>



> On Sep 21, 2021, at 4:21 AM, Chaitanya Kulkarni <chaitanyak@nvidia.com> wrote:
> 
> From: Chaitanya Kulkarni <kch@nvidia.com>
> 
> Output defects can exist in sysfs content using sprintf and snprintf.
> 

Small nit.. I would remove above line from patch 1 - 5. 

Below commit message describes it better.
 

> sprintf does not know the PAGE_SIZE maximum of the temporary buffer
> used for outputting sysfs content and it's possible to overrun the
> PAGE_SIZE buffer length.
> 
> Use a generic sysfs_emit function that knows that the size of the

Also in above line, I would remove second “that” (same for patches 1 - 5)

> temporary buffer and ensures that no overrun is done for offset
> attribute.
> 
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/block/loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 7bf4686af774..e37444977ae6 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -856,7 +856,7 @@ static ssize_t loop_attr_backing_file_show(struct loop_device *lo, char *buf)
> 
> static ssize_t loop_attr_offset_show(struct loop_device *lo, char *buf)
> {
> -	return sprintf(buf, "%llu\n", (unsigned long long)lo->lo_offset);
> +	return sysfs_emit(buf, "%llu\n", (unsigned long long)lo->lo_offset);
> }
> 
> static ssize_t loop_attr_sizelimit_show(struct loop_device *lo, char *buf)
> -- 
> 2.29.0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


  reply	other threads:[~2021-09-21 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21  9:21 [PATCH 0/8] loop: small clenaup Chaitanya Kulkarni
2021-09-21  9:21 ` [PATCH 1/8] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni
2021-09-21 13:33   ` Himanshu Madhani [this message]
2021-09-21  9:21 ` [PATCH 2/8] loop: use sysfs_emit() in the sysfs sizelimit show Chaitanya Kulkarni
2021-09-21 13:35   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 3/8] loop: use sysfs_emit() in the sysfs autoclear show Chaitanya Kulkarni
2021-09-21 13:35   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 4/8] loop: use sysfs_emit() in the sysfs partscan show Chaitanya Kulkarni
2021-09-21 13:35   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 5/8] loop: use sysfs_emit() in the sysfs dio show Chaitanya Kulkarni
2021-09-21 13:36   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 6/8] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2021-09-21 13:36   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 7/8] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2021-09-21 13:37   ` Himanshu Madhani
2021-09-21  9:21 ` [PATCH 8/8] loop: allow user to set the queue depth Chaitanya Kulkarni
2021-09-21 13:38   ` Himanshu Madhani
2022-02-14 10:01 [PATCH 0/8] loop: cleanup and few improvements Chaitanya Kulkarni
2022-02-14 10:01 ` [PATCH 1/8] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=759AF0F5-B424-4F96-800A-45E8DF944296@oracle.com \
    --to=himanshu.madhani@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).