From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, Yanhui Ma <yama@redhat.com>,
John Garry <john.garry@huawei.com>,
Bart Van Assche <bvanassche@acm.org>,
kashyap.desai@broadcom.com
Subject: Re: [PATCH] blk-mq: plug request for shared sbitmap
Date: Fri, 14 May 2021 08:59:18 -0600 [thread overview]
Message-ID: <75ca571b-c132-245f-2fb0-159cc6aa4923@kernel.dk> (raw)
In-Reply-To: <20210514022052.1047665-1-ming.lei@redhat.com>
On 5/13/21 8:20 PM, Ming Lei wrote:
> In case of shared sbitmap, request won't be held in plug list any more
> sine commit 32bc15afed04 ("blk-mq: Facilitate a shared sbitmap per
> tagset"), this way makes request merge from flush plug list & batching
> submission not possible, so cause performance regression.
>
> Yanhui reports performance regression when running sequential IO
> test(libaio, 16 jobs, 8 depth for each job) in VM, and the VM disk
> is emulated with image stored on xfs/megaraid_sas.
>
> Fix the issue by recovering original behavior to allow to hold request
> in plug list.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-05-14 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 2:20 [PATCH] blk-mq: plug request for shared sbitmap Ming Lei
2021-05-14 14:59 ` Jens Axboe [this message]
2021-05-18 9:44 ` John Garry
2021-05-18 11:16 ` Ming Lei
2021-05-18 11:42 ` John Garry
2021-05-18 12:00 ` Ming Lei
2021-05-18 12:51 ` John Garry
2021-05-18 16:01 ` John Garry
2021-05-19 0:21 ` Ming Lei
2021-05-19 8:41 ` John Garry
2021-05-20 1:23 ` Ming Lei
2021-05-20 8:21 ` John Garry
2021-05-18 11:54 ` Hannes Reinecke
2021-05-18 12:37 ` John Garry
2021-05-18 13:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75ca571b-c132-245f-2fb0-159cc6aa4923@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yama@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).