From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D67EC4338F for ; Fri, 6 Aug 2021 06:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDB79611CA for ; Fri, 6 Aug 2021 06:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243346AbhHFGeI (ORCPT ); Fri, 6 Aug 2021 02:34:08 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51824 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbhHFGeH (ORCPT ); Fri, 6 Aug 2021 02:34:07 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D1EB21FE9B; Fri, 6 Aug 2021 06:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628231631; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zl842g0bWie6vqzv1++O8vKc9vEk5pvbJfOEXYua4rQ=; b=z47Oc/iONezDdNpSOLmR5ppTBkF49M/RJp84t/0LC0p858kh6+SrDPhrhJTICoRw9awRfz PFWNMEgB7PweXJ5izNQUaFzyu8VUcG9SuNQieJJ6SL8WLmNYViw8FoH3ySLIH/pXqlrZOR mmUHNJDkdE8FZked6YK/th66pqg6m4o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628231631; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zl842g0bWie6vqzv1++O8vKc9vEk5pvbJfOEXYua4rQ=; b=Uh3Df/Ps6hlMO/dGmNVjG3InGRAZfhScidCoPj/Oo8hgOsy/gwNmD2wS09V3t11gLKHXVy h/RDWQHSqlECSlDA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 88DEF136D9; Fri, 6 Aug 2021 06:33:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id qwLpHs/XDGGmBQAAGKfGzw (envelope-from ); Fri, 06 Aug 2021 06:33:51 +0000 Subject: Re: [PATCH v2 1/4] block: bfq: fix bfq_set_next_ioprio_data() To: Damien Le Moal , Jens Axboe , linux-block@vger.kernel.org, Paolo Valente , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim , Chao Yu References: <20210806051140.301127-1-damien.lemoal@wdc.com> <20210806051140.301127-2-damien.lemoal@wdc.com> From: Hannes Reinecke Message-ID: <763e1397-f738-d812-52a2-759e1974ecd7@suse.de> Date: Fri, 6 Aug 2021 08:33:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210806051140.301127-2-damien.lemoal@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/6/21 7:11 AM, Damien Le Moal wrote: > For a request that has a priority level equal to or larger than > IOPRIO_BE_NR, bfq_set_next_ioprio_data() prints a critical warning but > defaults to setting the request new_ioprio field to IOPRIO_BE_NR. This > is not consistent with the warning and the allowed values for priority > levels. Fix this by setting the request new_ioprio field to > IOPRIO_BE_NR - 1, the lowest priority level allowed. > > Cc: > Fixes: aee69d78dec0 ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler") > Signed-off-by: Damien Le Moal > --- > block/bfq-iosched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer