From: Josef Bacik <josef@toxicpanda.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
Xiubo Li <xiubli@redhat.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: nbd lifetimes fixes
Date: Wed, 25 Aug 2021 16:14:58 -0400 [thread overview]
Message-ID: <78dad9ba-c89e-2a30-c083-16ef0324b48e@toxicpanda.com> (raw)
In-Reply-To: <20210825163108.50713-1-hch@lst.de>
On 8/25/21 12:31 PM, Christoph Hellwig wrote:
> Hi Josef and Jens,
>
> this series tries to deal with the fallout of the recent lock scope
> reduction as pointed out by Tetsuo and szybot and inspired by /
> reused from the catchall patch by Tetsuo. One big change is that
> I finally decided to kill off the ->destroy_complete scheme entirely
> because I'm pretty sure it is not needed with the various fixes and
> we can just return an error for the tiny race condition where it
> matters. Xiubo, can you double check this with your nbd-runner
> setup? nbd-runner itself seems pretty generic and not directly
> reproduce anything here.
>
> Note that the syzbot reproduer still fails eventually, but in
> devtmpfsd in a way that does not look related to the loop code
> at all.
>
Looks good to me, you can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2021-08-25 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 16:31 nbd lifetimes fixes Christoph Hellwig
2021-08-25 16:31 ` [PATCH 1/6] nbd: add missing locking to the nbd_dev_add error path Christoph Hellwig
2021-08-25 16:31 ` [PATCH 2/6] nbd: reset NBD to NULL when restarting in nbd_genl_connect Christoph Hellwig
2021-08-25 16:31 ` [PATCH 3/6] nbd: prevent IDR lookups from finding partially initialized devices Christoph Hellwig
2021-08-25 16:31 ` [PATCH 4/6] nbd: set nbd->index before releasing nbd_index_mutex Christoph Hellwig
2021-08-25 16:31 ` [PATCH 5/6] nbd: only return usable devices from nbd_find_unused Christoph Hellwig
2021-08-25 16:31 ` [PATCH 6/6] nbd: remove nbd->destroy_complete Christoph Hellwig
2021-08-25 20:14 ` Josef Bacik [this message]
2021-08-25 20:21 ` nbd lifetimes fixes Jens Axboe
2021-10-08 9:17 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78dad9ba-c89e-2a30-c083-16ef0324b48e@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).