linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: JackieLiu <liuyun01@kylinos.cn>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix stuck problem caused by potential memory alloc failure
Date: Wed, 10 Jul 2019 23:33:18 +0800	[thread overview]
Message-ID: <7E6A5863-5948-45B2-A7B7-C0CAEB8EDD8C@kylinos.cn> (raw)
In-Reply-To: <25691b9f-8c0f-0d19-d1db-4c4ce6dfb5a9@kernel.dk>

Thank you for pointing out. I haven't had time to pay attention to the new 
features of sqe links. When I was debugging another stuck problem, I found 
that there was no free the reference count, so I sent the patch about this.

Anyway, if necessary, I will resend the patch again, with your rewritten
comments.
 

> 在 2019年7月10日，21:57，Jens Axboe <axboe@kernel.dk> 写道：
> 
> On 7/10/19 2:35 AM, Jackie Liu wrote:
>> when io_req_defer alloc memory failed, it will be return -EAGAIN.
>> But io_submit_sqe cannot be returned immediately because the reference
>> count for req is still hold. we should be clean it.
> 
> Looks like this actually got fixed in my for-5.3/io_uring branch which
> I haven't pushed out yet. Once that's in, I'd suggest we send yours to
> stable separately. Probably change the wording to:
> 
> When io_req_defer alloc memory fails, it will be -EAGAIN. But
> io_submit_sqe cannot return immediately because the reference count for
> req is still held. Ensure that we free it.
> 
> -- 
> Jens Axboe
> 
> 




      reply	other threads:[~2019-07-10 15:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  8:35 [PATCH] io_uring: fix stuck problem caused by potential memory alloc failure Jackie Liu
2019-07-10 13:57 ` Jens Axboe
2019-07-10 15:33   ` JackieLiu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7E6A5863-5948-45B2-A7B7-C0CAEB8EDD8C@kylinos.cn \
    --to=liuyun01@kylinos.cn \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).