From: Bart Van Assche <bvanassche@acm.org>
To: "André Almeida" <andrealmeid@collabora.com>,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: corbet@lwn.net, axboe@kernel.dk, kernel@collabora.com,
krisman@collabora.com
Subject: Re: [PATCH v2 1/4] null_blk: do not fail the module load with zero devices
Date: Fri, 13 Sep 2019 15:17:53 -0700 [thread overview]
Message-ID: <7c0f4547-4193-bd3e-85c6-d950a004ac46@acm.org> (raw)
In-Reply-To: <20190913220300.422869-2-andrealmeid@collabora.com>
On 9/13/19 3:02 PM, André Almeida wrote:
> The module load should fail only if there is something wrong with the
> configuration or if an error prevents it to work properly. The module
> should be able to be loaded with (nr_device == 0), since it will not
> trigger errors or be in malfunction state. Preventing loading with zero
> devices also breaks applications that configures this module using
> configfs API. Remove the nr_device check to fix this.
I just noticed that this patch is necessary to unbreak blktests. The srp
tests fail as follows with Jens' for-next branch:
modprobe: ERROR: could not insert 'null_blk': Invalid argument
I think that error is triggered by the following statement in
common/multipath-over-rdma:
modprobe null_blk nr_devices=0 || return $?
Bart.
next prev parent reply other threads:[~2019-09-13 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 22:02 [PATCH v2 0/4] null_blk: fixes around nr_devices and log improvements André Almeida
2019-09-13 22:02 ` [PATCH v2 1/4] null_blk: do not fail the module load with zero devices André Almeida
2019-09-13 22:15 ` Chaitanya Kulkarni
2019-09-13 22:17 ` Bart Van Assche [this message]
2019-09-13 22:37 ` Chaitanya Kulkarni
2019-09-13 22:02 ` [PATCH v2 2/4] null_blk: match the type of parameter nr_devices André Almeida
2019-09-13 22:15 ` Chaitanya Kulkarni
2019-09-13 22:02 ` [PATCH v2 3/4] null_blk: format pr_* logs with pr_fmt André Almeida
2019-09-13 22:16 ` Chaitanya Kulkarni
2019-09-13 22:03 ` [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro André Almeida
2019-09-13 22:18 ` Chaitanya Kulkarni
2019-09-14 7:50 ` Jonathan Corbet
2019-09-16 13:38 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c0f4547-4193-bd3e-85c6-d950a004ac46@acm.org \
--to=bvanassche@acm.org \
--cc=andrealmeid@collabora.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).