From: Jens Axboe <axboe@kernel.dk>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] ataflop: Mark expected switch fall-through
Date: Mon, 29 Jul 2019 15:25:17 -0600 [thread overview]
Message-ID: <80ad9bf9-4d50-a436-586c-dd9775e3e186@kernel.dk> (raw)
In-Reply-To: <20190729211053.GA6735@embeddedor>
On 7/29/19 3:10 PM, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: m68k):
>
> drivers/block/ataflop.c: In function ‘fd_locked_ioctl’:
> drivers/block/ataflop.c:1728:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> set_capacity(floppy->disk, MAX_DISK_SIZE * 2);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/block/ataflop.c:1729:2: note: here
> case FDFMTEND:
> ^~~~
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-07-29 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:10 [PATCH] ataflop: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 21:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ad9bf9-4d50-a436-586c-dd9775e3e186@kernel.dk \
--to=axboe@kernel.dk \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).