From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Song Liu <songliubraving@fb.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
Song Liu <liu.song.a23@gmail.com>, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone
Date: Fri, 23 Aug 2019 14:48:35 -0300 [thread overview]
Message-ID: <8163258e-839c-e0b8-fc4b-74c94c9dae1d@canonical.com> (raw)
In-Reply-To: <73C4747E-7A9E-4833-8393-B6A06C935DBE@fb.com>
On 22/08/2019 18:55, Song Liu wrote:
> [...]
>> + if (unlikely(!(tmp_dev->rdev->bdev->bd_disk->flags & GENHD_FL_UP))) {
>> + if (!test_bit(MD_BROKEN, &mddev->flags))
>> + pr_warn("md: %s: linear array has a missing/failed member\n",
>> + mdname(mddev));
>> + set_bit(MD_BROKEN, &mddev->flags);
>> + bio_io_error(bio);
>> + return true;
>> + }
>> +
>
> Maybe we can somehow put this block in a helper and use it in both raid0
> and linear code?
>
> Otherwise, looks good to me.
>
> Thanks,
> Song
>
OK, so something as a function with a prototype like
"void md_is_broken(struct md_rdev *rd, const char *md_type)"
is good for you?
Then we can use that as the check if a member failed and in positive
case, we can print the message (if not printed before) and return to the
raid0/linear driver in order it fails the bio and returns.
I'd prefer keeping the bio out of the helper, agreed?
If you have suggestion for a better name, let me know.
Thanks,
Guilherme
next prev parent reply other threads:[~2019-08-23 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 16:13 [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Guilherme G. Piccoli
2019-08-22 16:13 ` [PATCH v3 2/2] mdadm: Introduce new array state 'broken' for raid0/linear Guilherme G. Piccoli
2019-08-22 21:56 ` Song Liu
2019-08-29 12:51 ` Guilherme G. Piccoli
2019-08-30 8:17 ` NeilBrown
2019-08-30 12:48 ` Guilherme G. Piccoli
2019-08-22 21:55 ` [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone Song Liu
2019-08-23 17:48 ` Guilherme G. Piccoli [this message]
2019-08-23 17:51 ` Song Liu
2019-08-30 10:47 ` Wols Lists
2019-08-30 11:25 ` Guilherme Piccoli
2019-09-03 19:53 ` Guilherme G. Piccoli
2019-08-30 8:08 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8163258e-839c-e0b8-fc4b-74c94c9dae1d@canonical.com \
--to=gpiccoli@canonical.com \
--cc=dm-devel@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=neilb@suse.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).