From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4612EC2D0A3 for ; Sun, 1 Nov 2020 16:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F5E722265 for ; Sun, 1 Nov 2020 16:45:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="C6/CfdYP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbgKAQp0 (ORCPT ); Sun, 1 Nov 2020 11:45:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgKAQp0 (ORCPT ); Sun, 1 Nov 2020 11:45:26 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D7AC0617A6 for ; Sun, 1 Nov 2020 08:45:24 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id h6so8737724pgk.4 for ; Sun, 01 Nov 2020 08:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JA2Mrg1CETiakxbFSgknGwTSjNWYLI4LI30te6RUQlo=; b=C6/CfdYPKDaybjemy7ROjgbyGvqWB8u46p2B5eG/nr68U2TGp2xvaVgp2iM+RQBZ+e vV4TDjQS6iV2HmZeWPg2tXHrVpg8bNCvWcTGkRCyfQM4VmTSm7ZkoYxM8E9U4qNpDugu Qax0PNfE8SJPPsu0S6mBjDQwFfvGp10HHDOlsLWe/na8mnnzwk9wfgZdtm/9swmogTuN MzUs4wDSAKQ84FXYmaRgT4XRnKdOog9fc8vkJy7193hpA168Vg4RCSDycjU8LT4CkDLf psgPKi8H66LLmuMPHcpmP2gIuP2Gy0GJ+RoHYRYrDqDnw+YBKkZKLYUYa5o/LThczwuA 1PPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JA2Mrg1CETiakxbFSgknGwTSjNWYLI4LI30te6RUQlo=; b=umDmDXNje408sIJJ+6rKoqnPZvHv1t6zcVjZecJOZ9EAYtAh6Nai9oklxI+behKEuQ QyTPcPg28aSOWFDIeXJy34ngrw9t+oM3ZX1D2+KrTApGeSK5/hvuIDZq6DuScR8qejgl CKvttBBiJDcVAKP50kXMR+CVdoI8brS9qZofRlviLq9UMWdyA7HNYX53dR671JUPFnD0 O0kxYjdiIK6MfEd96TiBQqspOhBovq7J4FCA9p+6SQeFx9B9KFbhE9Oit0KtV1RjlxT5 HDjnHRI9yL0vzeA6qe7Zn+DT/i2OeF3QyY6WDDIEJvJEaAkpszJzsbBPamVfk5I3YXe0 /8Tw== X-Gm-Message-State: AOAM532B6hHGoY+jQc/39mY4zUayGSO6IY5k1MMzfcMt0BKGR824LccY JYht98mpZ7JX3YAbaDEl0jz7Mw== X-Google-Smtp-Source: ABdhPJxoCG9gkDR5+SPv2EwBLd3ow0z0XlOgH7pokFA9cV+UVH6OXY3zdVqqdFKxBkTD88zb7corAQ== X-Received: by 2002:a63:5046:: with SMTP id q6mr10223402pgl.373.1604249124121; Sun, 01 Nov 2020 08:45:24 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id gf17sm3763037pjb.15.2020.11.01.08.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Nov 2020 08:45:23 -0800 (PST) Subject: Re: [PATCH 02/11] mtip32xx: return -ENOTTY for all unhanled ioctls To: Christoph Hellwig Cc: Ilya Dryomov , Song Liu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Stefan Haberland , Jan Hoeppner , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org References: <20201031085810.450489-1-hch@lst.de> <20201031085810.450489-3-hch@lst.de> <20201101102735.GA26447@lst.de> From: Jens Axboe Message-ID: <842f4d23-b8c2-8ade-caf3-50b7cb9542cb@kernel.dk> Date: Sun, 1 Nov 2020 09:45:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201101102735.GA26447@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/1/20 3:27 AM, Christoph Hellwig wrote: > On Sat, Oct 31, 2020 at 08:58:52AM -0600, Jens Axboe wrote: >> On 10/31/20 2:58 AM, Christoph Hellwig wrote: >>> -ENOTTY is the convention for "driver does not support this ioctl". >>> Use it properly in mtip32xx instead of the bogys -EINVAL. >> >> While that's certainly true, there is a risk in making a change like this >> years after the fact. Not that I expect there are any mtip32xx users >> left at this point, but... > > -ENOTTY is what most drivers return. That being said we can keep the > old behavior, so if you prepfer that I can respin to do that. Yeah I know that -ENOTTY is what they all should use (and most of course does), just saying that this change carries some risk. Given that mtip32xx can probably be retired in the not-too-distant future, I say we just keep the -EINVAL here. -- Jens Axboe