From: Finn Thain <fthain@linux-m68k.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: linux-block@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] ataflop: unlock ataflop_probe_lock at atari_floppy_init()
Date: Sun, 17 Oct 2021 09:56:52 +1100 (AEDT) [thread overview]
Message-ID: <84fe74c6-9174-695b-563d-6ccbfa69ccd@linux-m68k.org> (raw)
In-Reply-To: <1d9351dc-baeb-1a54-625c-04ce01b009b0@i-love.sakura.ne.jp>
On Sat, 16 Oct 2021, Tetsuo Handa wrote:
> Commit bf9c0538e485b591 ("ataflop: use a separate gendisk for each media
> format") introduced ataflop_probe_lock mutex, but forgot to unlock the
> mutex when atari_floppy_init() (i.e. module loading) succeeded. If
> ataflop_probe() is called, it will deadlock on ataflop_probe_lock mutex.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Fixes: bf9c0538e485b591 ("ataflop: use a separate gendisk for each media format")
> ---
> To m68k users
>
> This patch suggests that nobody is testing this module using a real hardware.
> Can somebody test this module?
> Is current m68k hardware still supporting Atari floppy?
> If Atari floppy is no longer supported, do we still need this module?
>
It is only to be expected that no-one would have reported this bug yet.
2 months ago, Debian 11 shipped with a 5.10 kernel, but the bug you found
first appeared in Linux 5.11.
The existence of buggy drivers in mainline is undesirable but the real
problem here is the rate at which new bugs get added.
So I wonder if it would have been possible to use Aranym to find the
regression, or avoid it in the first place?
next prev parent reply other threads:[~2021-10-16 22:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 13:25 [PATCH] ataflop: unlock ataflop_probe_lock at atari_floppy_init() Tetsuo Handa
2021-10-16 22:56 ` Finn Thain [this message]
2021-10-17 1:52 ` Michael Schmitz
2021-10-17 2:09 ` [PATCH v2] ataflop: remove ataflop_probe_lock mutex Tetsuo Handa
2021-10-17 19:05 ` Michael Schmitz
2021-10-17 23:47 ` Michael Schmitz
2021-10-18 8:15 ` Michael Schmitz
2021-10-18 22:25 ` Michael Schmitz
2021-10-21 16:20 ` Luis Chamberlain
2021-10-21 16:21 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fe74c6-9174-695b-563d-6ccbfa69ccd@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).