From: Jens Axboe <axboe@fb.com>
To: Minchan Kim <minchan@kernel.org>
Cc: kernel-team@lge.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] block: do not put mq context in blk_mq_alloc_request_hctx
Date: Thu, 30 Mar 2017 08:12:28 -0600 [thread overview]
Message-ID: <8787097b-7da5-3ae7-7896-cd08f5376018@fb.com> (raw)
In-Reply-To: <1490851245-32245-1-git-send-email-minchan@kernel.org>
On 03/29/2017 11:20 PM, Minchan Kim wrote:
> In blk_mq_alloc_request_hctx, blk_mq_sched_get_request doesn't
> get sw context so we don't need to put the context with
> blk_mq_put_ctx. Unless, we will see preempt counter underflow.
Good catch, that's definitely a bug. I have applied your patch
for 4.11.
--
Jens Axboe
prev parent reply other threads:[~2017-03-30 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 5:20 [PATCH] block: do not put mq context in blk_mq_alloc_request_hctx Minchan Kim
2017-03-30 14:02 ` Sagi Grimberg
2017-03-30 14:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8787097b-7da5-3ae7-7896-cd08f5376018@fb.com \
--to=axboe@fb.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).