linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
Date: Thu, 4 Nov 2021 13:15:25 -0600	[thread overview]
Message-ID: <87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk> (raw)
In-Reply-To: <YYQuyt2/y1MgzRi0@infradead.org>

On 11/4/21 1:04 PM, Christoph Hellwig wrote:
> On Thu, Nov 04, 2021 at 01:02:54PM -0600, Jens Axboe wrote:
>> On 11/4/21 12:52 PM, Christoph Hellwig wrote:
>>> Looks good:
>>>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>> So these two are now:
>>
>> https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.16/block&id=c98cb5bbdab10d187aff9b4e386210eb2332af96
>>
>> which is the one I sent here, and then the next one gets cleaned up to
>> remove that queue enter helper:
>>
>> https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.16/block&id=7f930eb31eeb07f1b606b3316d8ad3ab6a92905b
>>
>> Can I add your reviewed-by to this last one as well? Only change is the
>> removal of blk_mq_enter_queue() and the weird construct there, it's just
>> bio_queue_enter() now.
> 
> Sure.

Thanks, prematurely already done, as you could tell :-)

Thanks for the reviews.

-- 
Jens Axboe


  reply	other threads:[~2021-11-04 19:15 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 18:21 [PATCHSET v3 0/5] Alloc batch fixes Jens Axboe
2021-11-04 18:21 ` [PATCH 1/5] block: have plug stored requests hold references to the queue Jens Axboe
2021-11-04 18:34   ` Christoph Hellwig
2021-11-04 18:35     ` Jens Axboe
2021-11-04 18:21 ` [PATCH 2/5] block: split request allocation components into helpers Jens Axboe
2021-11-04 18:35   ` Christoph Hellwig
2021-11-04 18:21 ` [PATCH 3/5] block: make blk_try_enter_queue() available for blk-mq Jens Axboe
2021-11-04 18:22 ` [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio() Jens Axboe
2021-11-04 18:36   ` Christoph Hellwig
2021-11-04 18:37     ` Jens Axboe
2021-11-04 18:39       ` Christoph Hellwig
2021-11-04 18:40         ` Jens Axboe
2021-11-04 18:45           ` Jens Axboe
2021-11-04 18:52             ` Christoph Hellwig
2021-11-04 19:02               ` Jens Axboe
2021-11-04 19:04                 ` Christoph Hellwig
2021-11-04 19:15                   ` Jens Axboe [this message]
2021-11-11 12:58                     ` Geert Uytterhoeven
2021-11-11 13:19                       ` Martin K. Petersen
2021-11-11 14:48                         ` Geert Uytterhoeven
2021-11-11 15:36                           ` Martin K. Petersen
2021-11-11 21:35                           ` Michael Schmitz
2021-11-12  7:37                             ` Geert Uytterhoeven
2021-11-12 22:34                               ` Michael Schmitz
2021-11-13  7:02                                 ` Michael Schmitz
2021-11-13 10:06                                 ` Geert Uytterhoeven
2021-11-13 22:11                               ` Michael Schmitz
2021-11-11 13:44                       ` Ming Lei
2021-11-11 14:51                         ` Geert Uytterhoeven
2021-11-11 15:23                           ` Ming Lei
2021-11-11 22:17                             ` Jens Axboe
2021-11-12  0:44                               ` Ming Lei
2021-11-12  7:51                                 ` Geert Uytterhoeven
2021-11-15 19:23                                   ` Michael Schmitz
2021-11-04 18:22 ` [PATCH 5/5] block: ensure cached plug request matches the current queue Jens Axboe
2021-11-04 18:36   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2021-11-04 15:21 [PATCHSET v2 0/5] Alloc batch fixes Jens Axboe
2021-11-04 15:22 ` [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).