linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
@ 2021-05-05 19:36 Enrico Granata
       [not found] ` <CAPR809ukYeThsPy4eg8A-G8b4Hwt7Prxh9P75=Vp9jnCKb6WqQ@mail.gmail.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Enrico Granata @ 2021-05-05 19:36 UTC (permalink / raw)
  To: virtio-dev; +Cc: egranata, hch, mst, linux-block, virtualization

In the course of review, some concerns were surfaced about the
original virtio-blk lifetime proposal, as it depends on the eMMC
spec which is not open

Add a more detailed description of the meaning of the fields
added by that proposal to the virtio-blk specification, as to
make it feasible to understand and implement the new lifetime
metrics feature without needing to refer to JEDEC's specification

This patch does not change the meaning of those fields nor add
any new fields, but it is intended to provide an open and more
clear description of the meaning associated with those fields.

Signed-off-by: Enrico Granata <egranata@google.com>
---
Changes in v2:
  - clarified JEDEC references;
  - added VIRTIO_BLK prefix and cleaned up comment syntax;
  - clarified reserved block references

 content.tex | 40 ++++++++++++++++++++++++++++++++--------
 1 file changed, 32 insertions(+), 8 deletions(-)

diff --git a/content.tex b/content.tex
index 9232d5c..804383a 100644
--- a/content.tex
+++ b/content.tex
@@ -4668,14 +4668,28 @@ \subsection{Device Operation}\label{sec:Device Types / Block Device / Device Ope
 };
 \end{lstlisting}
 
-The device lifetime metrics \field{pre_eol_info}, \field{device_lifetime_est_a}
-and \field{device_lifetime_est_b} have the semantics described by the JESD84-B50
-specification for the extended CSD register fields \field{PRE_EOL_INFO}
-\field{DEVICE_LIFETIME_EST_TYP_A} and \field{DEVICE_LIFETIME_EST_TYP_B}
-respectively.
+The \field{pre_eol_info} specifies the percentage of reserved blocks
+that are consumed and will have one of these values:
 
-JESD84-B50 is available at the JEDEC website (https://www.jedec.org)
-pursuant to JEDEC's licensing terms and conditions.
+\begin{lstlisting}
+/* Value not available */
+#define VIRTIO_BLK_PRE_EOL_INFO_UNDEFINED    0
+/* < 80% of reserved blocks are consumed */
+#define VIRTIO_BLK_PRE_EOL_INFO_NORMAL       1
+/* 80% of reserved blocks are consumed */
+#define VIRTIO_BLK_PRE_EOL_INFO_WARNING      2
+/* 90% of reserved blocks are consumed */
+#define VIRTIO_BLK_PRE_EOL_INFO_URGENT       3
+/* All others values are reserved */
+\end{lstlisting}
+
+The \field{device_lifetime_est_typ_a} refers to wear of SLC cells and is provided
+in increments of 10%, with 0 meaning undefined, 1 meaning up-to 10% of lifetime
+used, and so on, thru to 11 meaning estimated lifetime exceeded.
+All values above 11 are reserved.
+
+The \field{device_lifetime_est_typ_b} refers to wear of MLC cells and is provided
+with the same semantics as \field{device_lifetime_est_typ_a}.
 
 The final \field{status} byte is written by the device: either
 VIRTIO_BLK_S_OK for success, VIRTIO_BLK_S_IOERR for device or driver
@@ -4812,7 +4826,17 @@ \subsection{Device Operation}\label{sec:Device Types / Block Device / Device Ope
 or UFS persistent storage), the device SHOULD offer the VIRTIO_BLK_F_LIFETIME
 flag. The flag MUST NOT be offered if the device is backed by storage for which
 the lifetime metrics described in this document cannot be obtained or for which
-such metrics have no useful meaning.
+such metrics have no useful meaning. If the metrics are offered, the device MUST NOT
+send any reserved values, as defined in this specification.
+
+\begin{note}
+  The device lifetime metrics \field{pre_eol_info}, \field{device_lifetime_est_a}
+  and \field{device_lifetime_est_b} are discussed in the JESD84-B50 specification.
+
+  The complete JESD84-B50 is available at the JEDEC website (https://www.jedec.org)
+  pursuant to JEDEC's licensing terms and conditions. This information is provided to
+  simplfy passthrough implementations from eMMC devices.
+\end{note}
 
 \subsubsection{Legacy Interface: Device Operation}\label{sec:Device Types / Block Device / Device Operation / Legacy Interface: Device Operation}
 When using the legacy interface, transitional devices and drivers
-- 
2.31.1.527.g47e6f16901-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
       [not found]     ` <87pmvlck3p.fsf@redhat.com>
@ 2021-07-14 14:25       ` Stefan Hajnoczi
  2021-08-06 19:19         ` Enrico Granata
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2021-07-14 14:25 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Enrico Granata, virtio-dev, linux-block, virtualization, hch

[-- Attachment #1: Type: text/plain, Size: 2336 bytes --]

On Wed, Jul 14, 2021 at 11:36:58AM +0200, Cornelia Huck wrote:
> On Wed, Jul 14 2021, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> > On Wed, May 05, 2021 at 12:37:26PM -0700, Enrico Granata wrote:
> >> ---------- Forwarded message ---------
> >> From: Enrico Granata <egranata@google.com>
> >> Date: Wed, May 5, 2021 at 1:37 PM
> >> Subject: [PATCH v2] Provide detailed specification of virtio-blk
> >> lifetime metrics
> >> To: <virtio-dev@lists.oasis-open.org>
> >> Cc: <egranata@google.com>, <hch@infradead.org>, <mst@redhat.com>,
> >> <linux-block@vger.kernel.org>,
> >> <virtualization@lists.linux-foundation.org>
> >> 
> >> 
> >> In the course of review, some concerns were surfaced about the
> >> original virtio-blk lifetime proposal, as it depends on the eMMC
> >> spec which is not open
> >> 
> >> Add a more detailed description of the meaning of the fields
> >> added by that proposal to the virtio-blk specification, as to
> >> make it feasible to understand and implement the new lifetime
> >> metrics feature without needing to refer to JEDEC's specification
> >> 
> >> This patch does not change the meaning of those fields nor add
> >> any new fields, but it is intended to provide an open and more
> >> clear description of the meaning associated with those fields.
> >> 
> >> Signed-off-by: Enrico Granata <egranata@google.com>
> >> ---
> >> Changes in v2:
> >>   - clarified JEDEC references;
> >>   - added VIRTIO_BLK prefix and cleaned up comment syntax;
> >>   - clarified reserved block references
> >> 
> >>  content.tex | 40 ++++++++++++++++++++++++++++++++--------
> >>  1 file changed, 32 insertions(+), 8 deletions(-)
> >
> > Ping?
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> [Enrico is currently on leave of absence]
> 
> Is there any outstanding feedback from the linux-block folks? I've lost
> track of this, I'm afraid. (Your R-b is the only feedback I see on this
> list...)
> 
> We can certainly put up a vote. This is one of the things I wanted to
> see fixed for the next release of the standard.

I have CCed Christoph, linux-block@, and virtualization@. Here is the
link to the patch that we're discussing:
https://patchwork.kernel.org/project/linux-block/patch/20210505193655.2414268-1-egranata@google.com/

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
  2021-07-14 14:25       ` [virtio-dev] Fwd: " Stefan Hajnoczi
@ 2021-08-06 19:19         ` Enrico Granata
  2021-10-06 11:54           ` Cornelia Huck
  0 siblings, 1 reply; 6+ messages in thread
From: Enrico Granata @ 2021-08-06 19:19 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: Cornelia Huck, virtio-dev, linux-block, virtualization, hch

Hi folks,
I am back from my leave of absence, so thank you everyone for your patience

This proposal has been outstanding for a while and didn't seem to
receive pushback, especially compared to the initial proposal

Would it be the right time to put this modification up for a vote?

Thanks,
- Enrico

Thanks,
- Enrico


On Wed, Jul 14, 2021 at 8:25 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Wed, Jul 14, 2021 at 11:36:58AM +0200, Cornelia Huck wrote:
> > On Wed, Jul 14 2021, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > > On Wed, May 05, 2021 at 12:37:26PM -0700, Enrico Granata wrote:
> > >> ---------- Forwarded message ---------
> > >> From: Enrico Granata <egranata@google.com>
> > >> Date: Wed, May 5, 2021 at 1:37 PM
> > >> Subject: [PATCH v2] Provide detailed specification of virtio-blk
> > >> lifetime metrics
> > >> To: <virtio-dev@lists.oasis-open.org>
> > >> Cc: <egranata@google.com>, <hch@infradead.org>, <mst@redhat.com>,
> > >> <linux-block@vger.kernel.org>,
> > >> <virtualization@lists.linux-foundation.org>
> > >>
> > >>
> > >> In the course of review, some concerns were surfaced about the
> > >> original virtio-blk lifetime proposal, as it depends on the eMMC
> > >> spec which is not open
> > >>
> > >> Add a more detailed description of the meaning of the fields
> > >> added by that proposal to the virtio-blk specification, as to
> > >> make it feasible to understand and implement the new lifetime
> > >> metrics feature without needing to refer to JEDEC's specification
> > >>
> > >> This patch does not change the meaning of those fields nor add
> > >> any new fields, but it is intended to provide an open and more
> > >> clear description of the meaning associated with those fields.
> > >>
> > >> Signed-off-by: Enrico Granata <egranata@google.com>
> > >> ---
> > >> Changes in v2:
> > >>   - clarified JEDEC references;
> > >>   - added VIRTIO_BLK prefix and cleaned up comment syntax;
> > >>   - clarified reserved block references
> > >>
> > >>  content.tex | 40 ++++++++++++++++++++++++++++++++--------
> > >>  1 file changed, 32 insertions(+), 8 deletions(-)
> > >
> > > Ping?
> > >
> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> > [Enrico is currently on leave of absence]
> >
> > Is there any outstanding feedback from the linux-block folks? I've lost
> > track of this, I'm afraid. (Your R-b is the only feedback I see on this
> > list...)
> >
> > We can certainly put up a vote. This is one of the things I wanted to
> > see fixed for the next release of the standard.
>
> I have CCed Christoph, linux-block@, and virtualization@. Here is the
> link to the patch that we're discussing:
> https://patchwork.kernel.org/project/linux-block/patch/20210505193655.2414268-1-egranata@google.com/
>
> Stefan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
  2021-08-06 19:19         ` Enrico Granata
@ 2021-10-06 11:54           ` Cornelia Huck
  2021-10-06 15:58             ` Enrico Granata
  0 siblings, 1 reply; 6+ messages in thread
From: Cornelia Huck @ 2021-10-06 11:54 UTC (permalink / raw)
  To: Enrico Granata, Stefan Hajnoczi
  Cc: virtio-dev, linux-block, virtualization, hch

On Fri, Aug 06 2021, Enrico Granata <egranata@google.com> wrote:

> Hi folks,
> I am back from my leave of absence, so thank you everyone for your patience
>
> This proposal has been outstanding for a while and didn't seem to
> receive pushback, especially compared to the initial proposal
>
> Would it be the right time to put this modification up for a vote?

I guess no news is good news? (Or it fell through the cracks for everybody...)

I can update #106 and start voting.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
  2021-10-06 11:54           ` Cornelia Huck
@ 2021-10-06 15:58             ` Enrico Granata
  2021-10-14 15:37               ` Cornelia Huck
  0 siblings, 1 reply; 6+ messages in thread
From: Enrico Granata @ 2021-10-06 15:58 UTC (permalink / raw)
  To: Cornelia Huck
  Cc: Stefan Hajnoczi, virtio-dev, linux-block, virtualization, hch

I would very much favor that - thanks for bringing this thread back to attention

Thanks,
- Enrico

Thanks,
- Enrico


On Wed, Oct 6, 2021 at 5:54 AM Cornelia Huck <cohuck@redhat.com> wrote:
>
> On Fri, Aug 06 2021, Enrico Granata <egranata@google.com> wrote:
>
> > Hi folks,
> > I am back from my leave of absence, so thank you everyone for your patience
> >
> > This proposal has been outstanding for a while and didn't seem to
> > receive pushback, especially compared to the initial proposal
> >
> > Would it be the right time to put this modification up for a vote?
>
> I guess no news is good news? (Or it fell through the cracks for everybody...)
>
> I can update #106 and start voting.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics
  2021-10-06 15:58             ` Enrico Granata
@ 2021-10-14 15:37               ` Cornelia Huck
  0 siblings, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2021-10-14 15:37 UTC (permalink / raw)
  To: Enrico Granata
  Cc: Stefan Hajnoczi, virtio-dev, linux-block, virtualization, hch

On Wed, Oct 06 2021, Enrico Granata <egranata@google.com> wrote:

> I would very much favor that - thanks for bringing this thread back to attention

Merged now, thank you for your patience.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-14 15:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 19:36 [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics Enrico Granata
     [not found] ` <CAPR809ukYeThsPy4eg8A-G8b4Hwt7Prxh9P75=Vp9jnCKb6WqQ@mail.gmail.com>
     [not found]   ` <YO6ro345FI0XE8vv@stefanha-x1.localdomain>
     [not found]     ` <87pmvlck3p.fsf@redhat.com>
2021-07-14 14:25       ` [virtio-dev] Fwd: " Stefan Hajnoczi
2021-08-06 19:19         ` Enrico Granata
2021-10-06 11:54           ` Cornelia Huck
2021-10-06 15:58             ` Enrico Granata
2021-10-14 15:37               ` Cornelia Huck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).