linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Davidlohr Bueso <dave@stgolabs.net>, axboe@kernel.dk
Cc: dbueso@suse.de, hch@infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/block: Goodbye BLK_DEV_UMEM
Date: Wed, 24 Mar 2021 08:17:40 +1100	[thread overview]
Message-ID: <87r1k5d0y3.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20210323191604.aqibane2w55q4oma@offworld>

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Tue, Mar 23 2021, Davidlohr Bueso wrote:

> I'm also Ccing Neil, who is one of the authors.

Thanks!
I have no objection to the removal.  The driver served its purpose at
the time, but technology has moved on.
Add
  Acked-by: NeilBrown <neilb@suse.de>
if you like (not necessary).

Thanks,
NeilBrown

>
> On Tue, 23 Mar 2021, Bueso wrote:
>
>>This removes the driver on the premise that it has been unused for a long
>>time. This is a better approach compared to changing untestable code nobody
>>cares about in the first place. Similarly, the umem.com website now shows a
>>mere Godaddy parking add.
>>
>>Suggested-by: Christoph Hellwig <hch@infradead.org>
>>Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>>---
>> arch/mips/configs/malta_defconfig       |    1 -
>> arch/mips/configs/malta_kvm_defconfig   |    1 -
>> arch/mips/configs/maltaup_xpa_defconfig |    1 -
>> drivers/block/Kconfig                   |   17 -
>> drivers/block/Makefile                  |    1 -
>> drivers/block/umem.c                    | 1130 -----------------------
>> drivers/block/umem.h                    |  132 ---
>> 7 files changed, 1283 deletions(-)
>> delete mode 100644 drivers/block/umem.c
>> delete mode 100644 drivers/block/umem.h

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

  reply	other threads:[~2021-03-23 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  0:48 [PATCH] block/umem: convert tasklet to threaded irq Davidlohr Bueso
2021-03-23 17:24 ` Christoph Hellwig
2021-03-23 17:27   ` Jens Axboe
2021-03-23 17:55     ` Davidlohr Bueso
2021-03-23 19:07     ` [PATCH] drivers/block: Goodbye BLK_DEV_UMEM Davidlohr Bueso
2021-03-23 19:16       ` Davidlohr Bueso
2021-03-23 21:17         ` NeilBrown [this message]
2021-03-24 12:58       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1k5d0y3.fsf@notabene.neil.brown.name \
    --to=neilb@suse.de \
    --cc=axboe@kernel.dk \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).