From: Paolo Bonzini <pbonzini@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Muneendra Kumar M <muneendra.kumar@broadcom.com>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
emilne@redhat.com, mkumar@redhat.com,
Gaurav Srivastava <gaurav.srivastava@broadcom.com>,
James Smart <jsmart2021@gmail.com>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [RFC 16/16] lpfc: vmid: Introducing vmid in io path.
Date: Thu, 6 Aug 2020 20:39:26 +0200 [thread overview]
Message-ID: <8850c528-725f-c89a-cdc6-a9abada80a69@redhat.com> (raw)
In-Reply-To: <20200806145901.GE4520@mtj.thefacebook.com>
On 06/08/20 16:59, Tejun Heo wrote:
>> If I understand correctly, your only objection is that you'd rather not
>> have it specified with a file under /sys/kernel/cgroup, and instead you
>> would prefer to have it implemented as a ioctl for a magic file
>> somewhere else in sysfs? I don't think there is any precedent for this,
>> and I'm not even sure where that sysfs file would be.
> It just doesn't fit in the cgroupfs. I don't know where it should go for
> this specific case. That's for you guys to figure out. There are multiple
> precedences - e.g. how perf or bpf hooks into cgroup and others that I can't
> remember off the top of my head.
perf and bpf have file descriptors, system calls and data structures of
their own, here there is simply none: it's just an array of chars. Can
you explain _why_ it doesn't fit in the cgroupfs?
Paolo
next prev parent reply other threads:[~2020-08-06 18:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 2:13 [RFC 00/16] Application specific identification support Muneendra
2020-08-04 2:13 ` [RFC 01/16] blkcg:Introduce blkio.app_identifier knob to blkio controller Muneendra
2020-08-04 11:31 ` Daniel Wagner
2020-08-04 14:21 ` Tejun Heo
2020-08-05 0:39 ` James Smart
2020-08-05 3:59 ` Ming Lei
2020-08-05 6:33 ` Hannes Reinecke
2020-08-05 14:39 ` Tejun Heo
2020-08-05 17:14 ` Muneendra Kumar M
2020-08-05 17:31 ` Tejun Heo
2020-08-06 2:22 ` Ming Lei
2020-08-06 12:31 ` Muneendra Kumar M
2020-08-06 13:41 ` Paolo Bonzini
2020-08-04 2:13 ` [RFC 02/16] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-08-04 2:13 ` [RFC 03/16] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-08-04 2:13 ` [RFC 04/16] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-08-04 2:13 ` [RFC 05/16] lpfc: vmid: Forward declarations for APIs Muneendra
2020-08-04 2:13 ` [RFC 06/16] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-08-04 2:13 ` [RFC 07/16] lpfc: vmid: VMID params initialization Muneendra
2020-08-04 2:13 ` [RFC 08/16] lpfc: vmid: vmid resource allocation Muneendra
2020-08-04 2:13 ` [RFC 09/16] lpfc: vmid: cleanup vmid resources Muneendra
2020-08-04 2:13 ` [RFC 10/16] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-08-04 2:13 ` [RFC 11/16] lpfc: vmid: Functions to manage vmids Muneendra
2020-08-04 2:13 ` [RFC 12/16] lpfc: vmid: Implements CT commands for appid Muneendra
2020-08-04 2:13 ` [RFC 13/16] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-08-04 2:13 ` [RFC 14/16] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-08-04 2:13 ` [RFC 15/16] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-08-04 2:13 ` [RFC 16/16] lpfc: vmid: Introducing vmid in io path Muneendra
2020-08-05 7:16 ` Hannes Reinecke
2020-08-05 23:38 ` James Smart
2020-08-06 12:34 ` Muneendra Kumar M
2020-08-06 14:32 ` Paolo Bonzini
2020-08-06 16:26 ` Muneendra Kumar M
2020-08-06 18:41 ` Paolo Bonzini
2020-08-07 11:24 ` Muneendra Kumar M
2020-08-07 11:38 ` Paolo Bonzini
2020-08-07 12:17 ` Muneendra Kumar M
2020-08-10 9:03 ` Paolo Bonzini
2020-08-10 12:13 ` Muneendra Kumar M
2020-08-12 7:54 ` Paolo Bonzini
2020-08-12 12:16 ` Muneendra Kumar M
2020-08-07 12:32 ` Muneendra Kumar M
2020-08-11 23:48 ` James Smart
2020-08-06 14:41 ` Tejun Heo
2020-08-06 14:46 ` Paolo Bonzini
2020-08-06 14:48 ` Tejun Heo
2020-08-06 14:54 ` Paolo Bonzini
2020-08-06 14:59 ` Tejun Heo
2020-08-06 18:39 ` Paolo Bonzini [this message]
2020-08-06 18:49 ` Tejun Heo
2020-08-06 19:20 ` Paolo Bonzini
2020-08-06 19:32 ` Tejun Heo
2020-08-07 12:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8850c528-725f-c89a-cdc6-a9abada80a69@redhat.com \
--to=pbonzini@redhat.com \
--cc=emilne@redhat.com \
--cc=gaurav.srivastava@broadcom.com \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).