From: Jens Axboe <axboe@kernel.dk>
To: Naohiro Aota <naohiro.aota@wdc.com>, linux-block@vger.kernel.org
Cc: johannes.thumshirn@wdc.com, Damien.LeMoal@wdc.com,
stable@vger.kernel.org
Subject: Re: [PATCH] block: advance iov_iter on bio_add_hw_page failure
Date: Wed, 28 Oct 2020 07:51:16 -0600 [thread overview]
Message-ID: <90183284-3ecc-c276-a77f-f13eff2a39cd@kernel.dk> (raw)
In-Reply-To: <7e91d39fccbd06efdee40ad119833dbfeafd2fb7.1603868801.git.naohiro.aota@wdc.com>
On 10/28/20 1:25 AM, Naohiro Aota wrote:
> When the bio's size reaches max_append_sectors, bio_add_hw_page returns
> 0 then __bio_iov_append_get_pages returns -EINVAL. This is an expected
> result of building a small enough bio not to be split in the IO path.
> However, iov_iter is not advanced in this case, causing the same pages
> are filled for the bio again and again.
>
> Fix the case by properly advancing the iov_iter for already processed
> pages.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-10-28 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:25 [PATCH] block: advance iov_iter on bio_add_hw_page failure Naohiro Aota
2020-10-28 8:45 ` Johannes Thumshirn
2020-10-28 13:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90183284-3ecc-c276-a77f-f13eff2a39cd@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).