From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-aio@kvack.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org, hch@lst.de, avi@scylladb.com,
jannh@google.com
Subject: Re: [PATCH 05/18] Add io_uring IO interface
Date: Tue, 5 Feb 2019 09:58:39 -0700 [thread overview]
Message-ID: <90ebd7ce-6821-aa71-fdba-1e59d30f3d69@kernel.dk> (raw)
In-Reply-To: <x49sgx3t9yv.fsf@segfault.boston.devel.redhat.com>
On 2/4/19 4:22 PM, Jeff Moyer wrote:
> Hi, Jens,
>
> Jens Axboe <axboe@kernel.dk> writes:
>
>> +static void io_ring_ctx_free(struct io_ring_ctx *ctx)
>> +{
>> + destroy_workqueue(ctx->sqo_wq);
>
> You need to make sure sqo_wq is non-null before calling
> destroy_workqueue.
Fixed, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2019-02-05 16:58 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 15:23 [PATCHSET v11] io_uring IO interface Jens Axboe
2019-02-01 15:23 ` [PATCH 01/18] fs: add an iopoll method to struct file_operations Jens Axboe
2019-02-01 15:23 ` [PATCH 02/18] block: wire up block device iopoll method Jens Axboe
2019-02-01 15:23 ` [PATCH 03/18] block: add bio_set_polled() helper Jens Axboe
2019-02-01 15:24 ` [PATCH 04/18] iomap: wire up the iopoll method Jens Axboe
2019-02-01 16:59 ` Bart Van Assche
2019-02-06 20:05 ` Jens Axboe
2019-02-01 15:24 ` [PATCH 05/18] Add io_uring IO interface Jens Axboe
2019-02-01 18:20 ` Florian Weimer
2019-02-05 16:58 ` Jens Axboe
2019-02-04 23:22 ` Jeff Moyer
2019-02-04 23:52 ` Jeff Moyer
2019-02-05 16:59 ` Jens Axboe
2019-02-05 16:58 ` Jens Axboe [this message]
2019-02-01 15:24 ` [PATCH 06/18] io_uring: add fsync support Jens Axboe
2019-02-01 15:24 ` [PATCH 07/18] io_uring: support for IO polling Jens Axboe
2019-02-01 15:24 ` [PATCH 08/18] fs: add fget_many() and fput_many() Jens Axboe
2019-02-01 15:24 ` [PATCH 09/18] io_uring: use fget/fput_many() for file references Jens Axboe
2019-02-01 15:24 ` [PATCH 10/18] io_uring: batch io_kiocb allocation Jens Axboe
2019-02-01 15:24 ` [PATCH 11/18] block: implement bio helper to add iter bvec pages to bio Jens Axboe
2019-02-01 15:24 ` [PATCH 12/18] io_uring: add support for pre-mapped user IO buffers Jens Axboe
2019-02-01 15:24 ` [PATCH 13/18] io_uring: add file set registration Jens Axboe
2019-02-01 15:24 ` [PATCH 14/18] io_uring: add submission polling Jens Axboe
2019-02-01 15:24 ` [PATCH 15/18] io_uring: add io_kiocb ref count Jens Axboe
2019-02-01 15:24 ` [PATCH 16/18] io_uring: add support for IORING_OP_POLL Jens Axboe
2019-02-01 15:24 ` [PATCH 17/18] io_uring: allow workqueue item to handle multiple buffered requests Jens Axboe
2019-02-01 15:24 ` [PATCH 18/18] io_uring: add io_uring_event cache hit information Jens Axboe
2019-02-01 22:52 ` [PATCHSET v11] io_uring IO interface Bart Van Assche
2019-02-02 13:52 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 19:55 [PATCHSET v12] " Jens Axboe
2019-02-07 19:55 ` [PATCH 05/18] Add " Jens Axboe
2019-02-07 20:15 ` Keith Busch
2019-02-07 20:16 ` Jens Axboe
2019-01-30 21:55 [PATCHSET v10] " Jens Axboe
2019-01-30 21:55 ` [PATCH 05/18] Add " Jens Axboe
2019-01-29 19:26 [PATCHSET v9] " Jens Axboe
2019-01-29 19:26 ` [PATCH 05/18] Add " Jens Axboe
2019-01-28 21:35 [PATCHSET v8] " Jens Axboe
2019-01-28 21:35 ` [PATCH 05/18] Add " Jens Axboe
2019-01-28 21:53 ` Jeff Moyer
2019-01-28 21:56 ` Jens Axboe
2019-01-28 22:32 ` Jann Horn
2019-01-28 23:46 ` Jens Axboe
2019-01-28 23:59 ` Jann Horn
2019-01-29 0:03 ` Jens Axboe
2019-01-29 0:31 ` Jens Axboe
2019-01-29 0:34 ` Jann Horn
2019-01-29 0:55 ` Jens Axboe
2019-01-29 0:58 ` Jann Horn
2019-01-29 1:01 ` Jens Axboe
2019-02-01 16:57 ` Matt Mullins
2019-02-01 17:04 ` Jann Horn
2019-02-01 17:23 ` Jann Horn
2019-02-01 18:05 ` Al Viro
2019-01-29 1:07 ` Jann Horn
2019-01-29 2:21 ` Jann Horn
2019-01-29 2:54 ` Jens Axboe
2019-01-29 3:46 ` Jens Axboe
2019-01-29 15:56 ` Jann Horn
2019-01-29 16:06 ` Jens Axboe
2019-01-29 2:21 ` Jens Axboe
2019-01-29 1:29 ` Jann Horn
2019-01-29 1:31 ` Jens Axboe
2019-01-29 1:32 ` Jann Horn
2019-01-29 2:23 ` Jens Axboe
2019-01-29 7:12 ` Bert Wesarg
2019-01-29 12:12 ` Florian Weimer
2019-01-29 13:35 ` Jens Axboe
2019-01-29 15:38 ` Jann Horn
2019-01-29 15:54 ` Jens Axboe
2019-01-29 16:55 ` Christoph Hellwig
2019-01-29 15:35 ` Jann Horn
2019-01-29 15:39 ` Jens Axboe
2019-01-23 15:35 [PATCHSET v7] " Jens Axboe
2019-01-23 15:35 ` [PATCH 05/18] Add " Jens Axboe
2019-01-28 14:57 ` Christoph Hellwig
2019-01-28 16:26 ` Jens Axboe
2019-01-28 16:34 ` Christoph Hellwig
2019-01-28 19:32 ` Jens Axboe
2019-01-28 18:25 ` Jens Axboe
2019-01-29 6:30 ` Christoph Hellwig
2019-01-29 11:58 ` Arnd Bergmann
2019-01-29 15:20 ` Jens Axboe
2019-01-29 16:18 ` Arnd Bergmann
2019-01-29 16:19 ` Jens Axboe
2019-01-29 16:26 ` Arnd Bergmann
2019-01-29 16:28 ` Jens Axboe
2019-01-29 16:46 ` Arnd Bergmann
2019-01-29 0:47 ` Andy Lutomirski
2019-01-29 1:20 ` Jens Axboe
2019-01-29 6:45 ` Christoph Hellwig
2019-01-29 12:05 ` Arnd Bergmann
2019-01-31 5:11 ` Andy Lutomirski
2019-01-31 16:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ebd7ce-6821-aa71-fdba-1e59d30f3d69@kernel.dk \
--to=axboe@kernel.dk \
--cc=avi@scylladb.com \
--cc=hch@lst.de \
--cc=jannh@google.com \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).