From: Jiri Slaby <jirislaby@kernel.org>
To: longli@linuxonhyperv.com, linux-fs@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Cc: Long Li <longli@microsoft.com>, Jonathan Corbet <corbet@lwn.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
Andra Paraschiv <andraprs@amazon.com>,
Siddharth Gupta <sidgup@codeaurora.org>,
Hannes Reinecke <hare@suse.de>,
linux-doc@vger.kernel.org
Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver
Date: Tue, 20 Jul 2021 13:10:04 +0200 [thread overview]
Message-ID: <90ed52d3-5095-9789-53f0-477ba70edc3b@kernel.org> (raw)
In-Reply-To: <1626751866-15765-3-git-send-email-longli@linuxonhyperv.com>
On 20. 07. 21, 5:31, longli@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/include/uapi/misc/hv_azure_blob.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> +/* Copyright (c) 2021 Microsoft Corporation. */
> +
> +#ifndef _AZ_BLOB_H
> +#define _AZ_BLOB_H
> +
> +#include <linux/kernel.h>
> +#include <linux/uuid.h>
Quoting from
https://lore.kernel.org/linux-doc/MWHPR21MB159375586D810EC5DCB66AF0D7039@MWHPR21MB1593.namprd21.prod.outlook.com/:
=====
Seems like a #include of asm/ioctl.h (or something similar)
is needed so that _IOWR is defined. Also, a #include
is needed for __u32, __aligned_u64, guid_t, etc.
=====
Why was no include added?
> +
> +/* user-mode sync request sent through ioctl */
> +struct az_blob_request_sync_response {
> + __u32 status;
> + __u32 response_len;
> +};
> +
> +struct az_blob_request_sync {
> + guid_t guid;
> + __u32 timeout;
> + __u32 request_len;
> + __u32 response_len;
> + __u32 data_len;
> + __u32 data_valid;
> + __aligned_u64 request_buffer;
> + __aligned_u64 response_buffer;
> + __aligned_u64 data_buffer;
> + struct az_blob_request_sync_response response;
> +};
> +
> +#define AZ_BLOB_MAGIC_NUMBER 'R'
> +#define IOCTL_AZ_BLOB_DRIVER_USER_REQUEST \
> + _IOWR(AZ_BLOB_MAGIC_NUMBER, 0xf0, \
> + struct az_blob_request_sync)
> +
> +#endif /* define _AZ_BLOB_H */
>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2021-07-20 11:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 3:31 [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob longli
2021-07-20 3:31 ` [Patch v4 1/3] Drivers: hv: vmbus: add support to ignore certain PCIE devices longli
2021-07-20 3:31 ` [Patch v4 2/3] Drivers: hv: add Azure Blob driver longli
2021-07-20 5:26 ` Greg Kroah-Hartman
2021-07-20 5:30 ` Greg Kroah-Hartman
2021-07-20 7:34 ` Greg Kroah-Hartman
2021-07-20 19:57 ` Long Li
2021-07-21 5:08 ` Greg Kroah-Hartman
2021-07-20 11:10 ` Jiri Slaby [this message]
2021-07-20 22:12 ` Long Li
2021-07-21 4:57 ` Jiri Slaby
2021-07-21 16:07 ` Long Li
2021-07-20 3:31 ` [Patch v4 3/3] Drivers: hv: Add to maintainer for Hyper-V/Azure drivers longli
2021-07-20 4:37 ` [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob Bart Van Assche
2021-07-20 6:01 ` Christoph Hellwig
2021-07-20 7:05 ` Long Li
2021-07-20 15:15 ` Bart Van Assche
2021-07-20 17:33 ` Long Li
2021-07-20 18:16 ` gregkh
2021-07-20 18:52 ` Long Li
2021-07-20 15:54 ` Greg KH
2021-07-20 18:37 ` Long Li
2021-07-21 5:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ed52d3-5095-9789-53f0-477ba70edc3b@kernel.org \
--to=jirislaby@kernel.org \
--cc=andraprs@amazon.com \
--cc=ben.widawsky@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fs@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=luzmaximilian@gmail.com \
--cc=rppt@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).