From: Bart Van Assche <bvanassche@acm.org>
To: Jack Wang <jinpuwang@gmail.com>,
linux-block@vger.kernel.org, linux-rdma@vger.kernel.org
Cc: axboe@kernel.dk, hch@infradead.org, sagi@grimberg.me,
leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca,
danil.kipnis@cloud.ionos.com, jinpu.wang@cloud.ionos.com,
rpenyaev@suse.de, pankaj.gupta@cloud.ionos.com
Subject: Re: [PATCH v9 04/25] RDMA/rtrs: core: lib functions shared between client and server modules
Date: Sat, 29 Feb 2020 16:47:12 -0800 [thread overview]
Message-ID: <91708531-46f2-3593-ae08-383a36feea5c@acm.org> (raw)
In-Reply-To: <20200221104721.350-5-jinpuwang@gmail.com>
On 2020-02-21 02:47, Jack Wang wrote:
> + wr = (struct ib_recv_wr) {
> + .wr_cqe = &iu->cqe,
> + .sg_list = &list,
> + .num_sge = 1,
> + };
The indentation of the above code looks weird to me.
> + wr = (struct ib_recv_wr) {
> + .wr_cqe = cqe,
> + };
Same comment here.
> + wr = (struct ib_send_wr) {
> + .wr_cqe = &iu->cqe,
> + .sg_list = &list,
> + .num_sge = 1,
> + .opcode = IB_WR_SEND,
> + .send_flags = IB_SEND_SIGNALED,
> + };
And here.
> + wr = (struct ib_rdma_wr) {
> + .wr.wr_cqe = &iu->cqe,
> + .wr.sg_list = sge,
> + .wr.num_sge = num_sge,
> + .rkey = rkey,
> + .remote_addr = rdma_addr,
> + .wr.opcode = IB_WR_RDMA_WRITE_WITH_IMM,
> + .wr.ex.imm_data = cpu_to_be32(imm_data),
> + .wr.send_flags = flags,
> + };
And here too.
> + /*
> + * If one of the sges has 0 size, the operation will fail with an
> + * length error
> + */
"an length error" -> "a length error"?
> + wr = (struct ib_send_wr) {
> + .wr_cqe = cqe,
> + .send_flags = flags,
> + .opcode = IB_WR_RDMA_WRITE_WITH_IMM,
> + .ex.imm_data = cpu_to_be32(imm_data),
> + };
Please indent struct members.
> +int sockaddr_to_str(const struct sockaddr *addr, char *buf, size_t len)
> +{
> + int cnt;
> +
> + switch (addr->sa_family) {
> + case AF_IB:
> + cnt = scnprintf(buf, len, "gid:%pI6",
> + &((struct sockaddr_ib *)addr)->sib_addr.sib_raw);
> + return cnt;
> + case AF_INET:
> + cnt = scnprintf(buf, len, "ip:%pI4",
> + &((struct sockaddr_in *)addr)->sin_addr);
> + return cnt;
> + case AF_INET6:
> + cnt = scnprintf(buf, len, "ip:%pI6c",
> + &((struct sockaddr_in6 *)addr)->sin6_addr);
> + return cnt;
> + }
> + cnt = scnprintf(buf, len, "<invalid address family>");
> + pr_err("Invalid address family\n");
> + return cnt;
> +}
> +EXPORT_SYMBOL(sockaddr_to_str);
Please remove the 'cnt' variable from the above function.
Thanks,
Bart.
next prev parent reply other threads:[~2020-03-01 0:47 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 10:46 [PATCH v9 00/25] RTRS (former IBTRS) RDMA Transport Library and RNBD (former IBNBD) RDMA Network Block Device Jack Wang
2020-02-21 10:46 ` [PATCH v9 01/25] sysfs: export sysfs_remove_file_self() Jack Wang
2020-03-01 0:24 ` Bart Van Assche
2020-03-02 14:37 ` Jinpu Wang
2020-02-21 10:46 ` [PATCH v9 02/25] RDMA/rtrs: public interface header to establish RDMA connections Jack Wang
2020-03-01 0:31 ` Bart Van Assche
2020-03-02 8:39 ` Jinpu Wang
2020-03-03 9:40 ` Leon Romanovsky
2020-03-03 14:05 ` Jinpu Wang
2020-03-03 14:16 ` Leon Romanovsky
2020-03-03 14:23 ` Jinpu Wang
2020-02-21 10:46 ` [PATCH v9 03/25] RDMA/rtrs: private headers with rtrs protocol structs and helpers Jack Wang
2020-03-01 0:37 ` Bart Van Assche
2020-03-02 9:21 ` Jinpu Wang
2020-03-03 9:45 ` Leon Romanovsky
2020-03-03 13:52 ` Jinpu Wang
2020-03-03 14:05 ` Jason Gunthorpe
2020-03-03 16:13 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 04/25] RDMA/rtrs: core: lib functions shared between client and server modules Jack Wang
2020-03-01 0:47 ` Bart Van Assche [this message]
2020-03-02 8:40 ` Jinpu Wang
2020-03-03 9:57 ` Leon Romanovsky
2020-03-04 11:21 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 05/25] RDMA/rtrs: client: private header with client structs and functions Jack Wang
2020-03-01 0:51 ` Bart Van Assche
2020-03-02 13:49 ` Jinpu Wang
2020-03-02 16:13 ` Bart Van Assche
2020-03-02 16:18 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 06/25] RDMA/rtrs: client: main functionality Jack Wang
2020-03-01 1:33 ` Bart Van Assche
2020-03-02 13:20 ` Danil Kipnis
2020-03-03 16:04 ` Bart Van Assche
2020-03-04 16:43 ` Jinpu Wang
2020-03-04 16:49 ` Jason Gunthorpe
2020-03-05 11:26 ` Jinpu Wang
2020-03-05 13:27 ` Jason Gunthorpe
2020-03-05 13:37 ` Jinpu Wang
2020-03-05 13:54 ` Jason Gunthorpe
2020-03-06 13:33 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 07/25] RDMA/rtrs: client: statistics functions Jack Wang
2020-03-03 11:28 ` Leon Romanovsky
2020-03-03 11:46 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 08/25] RDMA/rtrs: client: sysfs interface functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 09/25] RDMA/rtrs: server: private header with server structs and functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 10/25] RDMA/rtrs: server: main functionality Jack Wang
2020-03-01 1:42 ` Bart Van Assche
2020-03-02 14:39 ` Jinpu Wang
2020-03-03 11:37 ` Leon Romanovsky
2020-03-03 16:41 ` Jinpu Wang
2020-03-03 16:59 ` Leon Romanovsky
2020-03-04 11:03 ` Jinpu Wang
2020-03-05 8:00 ` Leon Romanovsky
[not found] ` <CAHg0Huyc=pn1=WSKGLjm+c8AcchyQ8q7JS-0ToQyiBRgpGG=jA@mail.gmail.com>
2020-03-05 12:16 ` Leon Romanovsky
2020-03-05 12:28 ` Jinpu Wang
2020-03-05 12:35 ` Leon Romanovsky
2020-03-05 13:02 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 11/25] RDMA/rtrs: server: statistics functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 12/25] RDMA/rtrs: server: sysfs interface functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 13/25] RDMA/rtrs: include client and server modules into kernel compilation Jack Wang
2020-02-21 10:47 ` [PATCH v9 14/25] RDMA/rtrs: a bit of documentation Jack Wang
2020-02-21 10:47 ` [PATCH v9 15/25] block/rnbd: private headers with rnbd protocol structs and helpers Jack Wang
2020-03-01 2:12 ` Bart Van Assche
2020-03-02 16:37 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 16/25] block/rnbd: client: private header with client structs and functions Jack Wang
2020-03-01 2:26 ` Bart Van Assche
2020-03-02 14:59 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 17/25] block/rnbd: client: main functionality Jack Wang
2020-03-01 2:46 ` Bart Van Assche
2020-03-02 14:58 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 18/25] block/rnbd: client: sysfs interface functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 19/25] block/rnbd: server: private header with server structs and functions Jack Wang
2020-03-01 2:47 ` Bart Van Assche
2020-03-02 10:07 ` Danil Kipnis
2020-02-21 10:47 ` [PATCH v9 20/25] block/rnbd: server: main functionality Jack Wang
2020-03-01 2:58 ` Bart Van Assche
2020-03-02 9:58 ` Danil Kipnis
2020-03-03 5:57 ` Bart Van Assche
2020-02-21 10:47 ` [PATCH v9 21/25] block/rnbd: server: functionality for IO submission to file or block dev Jack Wang
2020-03-01 3:09 ` Bart Van Assche
2020-03-02 10:06 ` Danil Kipnis
2020-03-03 16:20 ` Jinpu Wang
2020-03-03 16:28 ` Bart Van Assche
2020-03-03 16:43 ` Jinpu Wang
2020-02-21 10:47 ` [PATCH v9 22/25] block/rnbd: server: sysfs interface functions Jack Wang
2020-02-21 10:47 ` [PATCH v9 23/25] block/rnbd: include client and server modules into kernel compilation Jack Wang
2020-02-21 10:47 ` [PATCH v9 24/25] block/rnbd: a bit of documentation Jack Wang
2020-02-21 10:47 ` [PATCH v9 25/25] MAINTAINERS: Add maintainers for RNBD/RTRS modules Jack Wang
2020-03-03 9:28 ` [PATCH v9 00/25] RTRS (former IBTRS) RDMA Transport Library and RNBD (former IBNBD) RDMA Network Block Device Leon Romanovsky
2020-03-04 14:06 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91708531-46f2-3593-ae08-383a36feea5c@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jinpuwang@gmail.com \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pankaj.gupta@cloud.ionos.com \
--cc=rpenyaev@suse.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).