From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E00C433DF for ; Thu, 21 May 2020 03:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D135B20748 for ; Thu, 21 May 2020 03:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728078AbgEUDvA (ORCPT ); Wed, 20 May 2020 23:51:00 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:52427 "EHLO mail-pj1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728015AbgEUDu7 (ORCPT ); Wed, 20 May 2020 23:50:59 -0400 Received: by mail-pj1-f49.google.com with SMTP id a5so2314022pjh.2 for ; Wed, 20 May 2020 20:50:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oG7Kr3qq6HZqX3noBJNU9dscDKKnqw+Ss4DPX+WY1KQ=; b=f/RC09PHRZVTfeWtQtGqq+HaYXsCDtYmUMCxnKcgOoLeRIwKphN4FzI+gk2c0DhyjC 8MHi8XZtESZ4N5kALW8Tzu/PQTF1jr4WNy8CqZiohGTi2lH2hXQ3ftYt7s+Ma7Q6bSQG SDlQrvgdNzmWH/lHuyHS45mduzozCBznetl5YSZT9SbyMGTZpW2B+M8iGa51lHCeEb6H bFsnzNoVMQ7SGBhF13Xq2MtYcFTW6vi8OfEXAhgvGmdIduIIfwKbbGQ9FI5uVWQJRiW2 YXUpy8aXjEr7Pq273GY4AohgTDa+utzDq2Fo3AJf3TDwa2el/DuynYA/Nc4dLNyNAjht wu+Q== X-Gm-Message-State: AOAM532b6bYeSq/gS0gS8bs/pT/KrzrI/ZFcsow7sO5CKZBdN3rUyWWZ +5Sw0UckPnUqudhgT+mXwVI= X-Google-Smtp-Source: ABdhPJxYNpmtHVxPZufJo0xJYFxrnUbKDKcPtfGGPnpYLZd0AJRbkrzx9VR668KcfipTrI7LusjpoQ== X-Received: by 2002:a17:90b:f0a:: with SMTP id br10mr8615814pjb.145.1590033058671; Wed, 20 May 2020 20:50:58 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:1522:29a6:14e1:9706? ([2601:647:4000:d7:1522:29a6:14e1:9706]) by smtp.gmail.com with ESMTPSA id w14sm2931026pgi.12.2020.05.20.20.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2020 20:50:57 -0700 (PDT) Subject: Re: blk-mq: improvement CPU hotplug (simplified version) v3 To: Ming Lei Cc: Christoph Hellwig , linux-block@vger.kernel.org, John Garry , Hannes Reinecke , Thomas Gleixner References: <20200520170635.2094101-1-hch@lst.de> <0cbc37cf-5439-c68c-3581-b3c436932388@acm.org> <20200521025744.GC735749@T590> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <9249e1cc-b6f2-010e-78d2-ead5a1b93464@acm.org> Date: Wed, 20 May 2020 20:50:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200521025744.GC735749@T590> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020-05-20 19:57, Ming Lei wrote: > On Wed, May 20, 2020 at 02:46:52PM -0700, Bart Van Assche wrote: >> If the CPU to which one of these interrupt vectors has >> been assigned is hotplugged, does that mean that four hardware queues >> have to be quiesced instead of only one as is done in patch 6/6? > > No, one hctx only becomes inactive after each CPU in hctx->cpumask is offline. > No matter how interrupt vector is assigned to hctx, requests shouldn't > be dispatched to that hctx any more. Since I haven't found an answer to my question in your reply I will rephrase my question. Suppose that there are 16 CPU cores, 16 hardware queues and that hctx->cpumask of each hardware queue i only contains CPU i. Suppose that four interrupt vectors (0, 1, 2 and 3) are used to report the completions for these hardware queues. Suppose that interrupt vector 3 is associated with hardware queues 12, 13, 14 and 15, and also that interrupt vector 3 is mapped to CPU core 14. My interpretation of patch 6/6 is that it will only quiesce hardware queue 14 but none of the other hardware queues associated with the same interrupt vector (hardware queues 12, 13 and 15). Isn't that a bug? Thanks, Bart.