From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F85C433E1 for ; Fri, 7 Aug 2020 14:07:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90A7C22C9F for ; Fri, 7 Aug 2020 14:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbgHGOHi (ORCPT ); Fri, 7 Aug 2020 10:07:38 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42453 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgHGOEB (ORCPT ); Fri, 7 Aug 2020 10:04:01 -0400 Received: by mail-pf1-f196.google.com with SMTP id 17so1041576pfw.9 for ; Fri, 07 Aug 2020 07:03:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EEK7qwrINpS0AR/Vn7KHw4tDcx330ztZP1xMqKuRyrs=; b=Ed7X6vo+ewO6D3Nqza3MXFVzQNT35BMpnso/t0T/7Z9cMb+0oKZsQrgTXz+RDsWgia jxHkUwJ1/6TKVbAtVKjIQ/+WTfb0CVPEBJBjiY1Egx8tRJkkHBK+s6b+iioKDmfD48XR FNFy59Truxf58Xwi93w3/ewIM29Eb99gV3m5bLL3NJ66tI8nLV1eMIsfPZqe36dTSpmw CraCl2fTUgs0yIzzW8IB4Y8rEIIqqx3EzBeo3MflItMI3wJuY/C0pey0DS0LM0+2DYHO s7pVM7HMqP9p62aMML5H63xVPpY422UREznEmacoseliHDtetobElm6Qyd8/uxYoeIDb JS+Q== X-Gm-Message-State: AOAM5304T0p9ZDORWZ9corF5Nld72/vg/E2mOYAh6axSjZvrtREIsNJd 7O2SlCdNAFl8vXYnXen1L1Y= X-Google-Smtp-Source: ABdhPJykpmFKNmixCd1ZJN51TBX4Tamosjc7RGHoywvvFCyOkdv0lE9ATyjd3zc3eXFFu1Ml7HSSgg== X-Received: by 2002:a63:541e:: with SMTP id i30mr12053466pgb.47.1596809035679; Fri, 07 Aug 2020 07:03:55 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id s29sm11398410pgo.68.2020.08.07.07.03.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 07:03:54 -0700 (PDT) Subject: Re: [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload To: Sagi Grimberg , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Omar Sandoval Cc: Chaitanya Kulkarni , Johannes Thumshirn , Christoph Hellwig , Keith Busch References: <20200806191518.593880-1-sagi@grimberg.me> <20200806191518.593880-7-sagi@grimberg.me> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <925e1ac6-38fa-6fe9-c0b7-7e665559a989@acm.org> Date: Fri, 7 Aug 2020 07:03:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200806191518.593880-7-sagi@grimberg.me> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020-08-06 12:15, Sagi Grimberg wrote: > There is no need to retry module unload for rdma_rxe > and siw. This also creates a dependency on > tests/nvmeof/rc which prevents it from using in > other test subsystems. If it wouldn't be necessary to retry module unload I wouldn't have introduced a loop. How about moving the unload_module() function definitions from tests/srp/rc and tests/nvmeof-mp/rc into common/rc instead? Thanks, Bart.