From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring: fix an issue when IOSQE_IO_LINK is inserted into defer list
Date: Thu, 15 Aug 2019 11:21:25 -0600 [thread overview]
Message-ID: <92805a41-a4b2-e42d-0132-b0f5e6f9c29e@kernel.dk> (raw)
In-Reply-To: <1565775322-10296-2-git-send-email-liuyun01@kylinos.cn>
On 8/14/19 3:35 AM, Jackie Liu wrote:
> This patch may fix two issues:
>
> First, when IOSQE_IO_DARIN set, the next IOs need to be inserted into defer
> list to delay execution, but link io will be actively scheduled to run by
> calling io_queue_sqe.
>
> Second, when multiple LINK_IOs are inserted together with defer_list, the
> LINK_IO is no longer keep order.
>
> |-------------|
> | LINK_IO | ----> insert to defer_list -----------
> |-------------| |
> | LINK_IO | ----> insert to defer_list ----------|
> |-------------| |
> | LINK_IO | ----> insert to defer_list ----------|
> |-------------| |
> | NORMAL_IO | ----> insert to defer_list ----------|
> |-------------| |
> |
> queue_work at same time <-----|
Looks good, applied.
--
Jens Axboe
next prev parent reply other threads:[~2019-08-15 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 9:35 [PATCH 1/2] io_uring: fix issue when IOSQE_IO_DRAIN pass with IOSQE_IO_LINK Jackie Liu
2019-08-14 9:35 ` [PATCH 2/2] io_uring: fix an issue when IOSQE_IO_LINK is inserted into defer list Jackie Liu
2019-08-15 17:21 ` Jens Axboe [this message]
2019-08-15 17:07 ` [PATCH 1/2] io_uring: fix issue when IOSQE_IO_DRAIN pass with IOSQE_IO_LINK Jens Axboe
2019-08-16 0:48 ` Jackie Liu
2019-08-16 1:21 ` Jens Axboe
2019-08-16 6:47 ` Jackie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92805a41-a4b2-e42d-0132-b0f5e6f9c29e@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).