From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 06/10] block: Fix the number of segment calculations
Date: Tue, 1 Nov 2022 10:23:32 -0700 [thread overview]
Message-ID: <934d8e30-8629-d598-0214-987580c349b8@acm.org> (raw)
In-Reply-To: <20221019222324.362705-7-bvanassche@acm.org>
On 10/19/22 15:23, Bart Van Assche wrote:
> Since multi-page bvecs are supported there can be multiple segments per
> bvec (see also bvec_split_segs()). Hence this patch that calculates the
> number of segments per bvec instead of assuming that there is only one
> segment per bvec.
(replying to my own email)
Hi Ming,
Do you agree that this patch fixes a bug introduced by the multi-page
bvec code and also that it is required even if the segment size is
larger than the page size?
Thanks,
Bart.
next prev parent reply other threads:[~2022-11-01 17:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:23 [PATCH 00/10] Support DMA segments smaller than the page size Bart Van Assche
2022-10-19 22:23 ` [PATCH 01/10] block: Remove request.write_hint Bart Van Assche
2022-10-21 1:59 ` Ming Lei
2022-10-19 22:23 ` [PATCH 02/10] block: Constify most queue limits pointers Bart Van Assche
2022-10-21 2:01 ` Ming Lei
2022-10-19 22:23 ` [PATCH 03/10] block: Micro-optimize get_max_segment_size() Bart Van Assche
2022-10-21 2:17 ` Ming Lei
2022-10-19 22:23 ` [PATCH 04/10] block: Add support for small segments in blk_rq_map_user_iov() Bart Van Assche
2022-10-19 22:23 ` [PATCH 05/10] block: Introduce QUEUE_FLAG_SUB_PAGE_SEGMENTS Bart Van Assche
2022-10-19 22:23 ` [PATCH 06/10] block: Fix the number of segment calculations Bart Van Assche
2022-11-01 17:23 ` Bart Van Assche [this message]
2022-11-02 1:22 ` Ming Lei
2022-11-03 19:32 ` Bart Van Assche
2022-10-19 22:23 ` [PATCH 07/10] block: Add support for segments smaller than the page size Bart Van Assche
2022-10-19 22:23 ` [PATCH 08/10] scsi: core: Set the SUB_PAGE_SEGMENTS request queue flag Bart Van Assche
2022-10-19 22:23 ` [PATCH 09/10] scsi_debug: Support configuring the maximum segment size Bart Van Assche
2022-10-19 22:23 ` [PATCH 10/10] null_blk: " Bart Van Assche
2022-10-20 23:13 ` Damien Le Moal
2022-10-20 23:34 ` Bart Van Assche
2022-10-20 23:39 ` Damien Le Moal
2022-10-21 0:39 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=934d8e30-8629-d598-0214-987580c349b8@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).