linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Ezequiel Garcia" <ezequiel@collabora.com>,
	"André Almeida" <andrealmeid@collabora.com>,
	linux-block@vger.kernel.org, linux-doc@vger.kernel.org
Cc: corbet@lwn.net, m@bjorling.me, kernel@collabora.com,
	krisman@collabora.com
Subject: Re: [PATCH 2/3] null_blk: fix module name at log message
Date: Thu, 12 Sep 2019 14:47:23 -0600	[thread overview]
Message-ID: <943a2fc3-4812-cc41-bdff-be13ec319257@kernel.dk> (raw)
In-Reply-To: <a02d9e6d9c13a607bc08b71a5d5f6c2039f1c279.camel@collabora.com>

On 9/12/19 9:47 AM, Ezequiel Garcia wrote:
> Hi André, Jens,
> 
> On Wed, 2019-09-11 at 11:46 -0300, André Almeida wrote:
>> The name of the module is "null_blk", not "null". Make `pr_info()` follow
>> the pattern of `pr_err()` log messages.
>>
> 
> Instead of doing these fixes manually, it's more consistent and smarter
> to use pr_fmt. There are many examples of drivers doing that.
> 
> I don't know if this patch can be dropped, and replaced with one used pr_fmt
> or if doesn't worth the trouble.
> 
> It would be even better to also patch Documentation/process/coding-style.rst,
> in particular the printing section, making a mention to pr_fmt.

André, please address the comments in this email and from Willy. Note
that the previous patch is queued up, so you'll need to make it relative
to that.

-- 
Jens Axboe


  reply	other threads:[~2019-09-12 20:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 14:46 [PATCH 1/3] docs: block: null_blk: enhance document style André Almeida
2019-09-11 14:46 ` [PATCH 2/3] null_blk: fix module name at log message André Almeida
2019-09-12 15:47   ` Ezequiel Garcia
2019-09-12 20:47     ` Jens Axboe [this message]
2019-09-12 22:08       ` André Almeida
2019-09-11 14:46 ` [PATCH 3/3] null_blk: validated the number of devices André Almeida
2019-09-12 16:19   ` Matthew Wilcox
2019-09-12 22:07     ` André Almeida
2019-09-12 22:20       ` Chaitanya Kulkarni
2019-09-13 14:57         ` André Almeida
2019-09-13 15:12           ` Matthew Wilcox
2019-09-13 15:39             ` André Almeida
2019-09-13 16:23             ` Jens Axboe
2019-09-13 16:27               ` Chaitanya Kulkarni
2019-09-13 16:48                 ` Jens Axboe
2019-09-11 22:05 ` [PATCH 1/3] docs: block: null_blk: enhance document style Jens Axboe
2019-09-11 22:26   ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=943a2fc3-4812-cc41-bdff-be13ec319257@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=andrealmeid@collabora.com \
    --cc=corbet@lwn.net \
    --cc=ezequiel@collabora.com \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).