From: "Pavel Begunkov (Silence)" <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>,
kbuild test robot <lkp@intel.com>
Subject: [PATCH v3] io_uring: Fix reversed nonblock flag
Date: Fri, 4 Oct 2019 17:01:08 +0300 [thread overview]
Message-ID: <9752f33f509287c77801d5e807213cff9195197a.1570197234.git.asml.silence@gmail.com> (raw)
In-Reply-To: <eecaf117de4894b595f300b9fb567825330b2d24.1570183599.git.asml.silence@gmail.com>
From: Pavel Begunkov <asml.silence@gmail.com>
io_queue_link_head() accepts @force_nonblock flag, but io_ring_submit()
passes something opposite.
v2: build error from test robot: Rebase to block-tree
v3: simplify with Jens suggestion
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index c934f91c51e9..b58c3d8594d8 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2761,7 +2761,7 @@ static int io_ring_submit(struct io_ring_ctx *ctx, unsigned int to_submit,
if (link)
io_queue_link_head(ctx, link, &link->submit, shadow_req,
- block_for_last);
+ !block_for_last);
if (statep)
io_submit_state_end(statep);
--
2.23.0
next prev parent reply other threads:[~2019-10-04 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 8:25 [PATCH] io_uring: Fix reversed nonblock flag Pavel Begunkov (Silence)
2019-10-04 8:32 ` Pavel Begunkov
2019-10-04 9:23 ` kbuild test robot
2019-10-04 9:33 ` kbuild test robot
2019-10-04 10:07 ` [PATCH v2] " Pavel Begunkov (Silence)
2019-10-04 13:05 ` Jens Axboe
2019-10-04 13:58 ` Pavel Begunkov
2019-10-04 14:01 ` Pavel Begunkov (Silence) [this message]
2019-10-04 14:04 ` [PATCH v3] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9752f33f509287c77801d5e807213cff9195197a.1570197234.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).