archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <>
To: Yufen Yu <>
Cc:, Jan Kara <>,
	Christoph Hellwig <>
Subject: Re: [PATCH v2] block: check disk exist before trying to add partition
Date: Wed, 30 Jun 2021 19:39:36 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 6/9/21 8:32 PM, Yufen Yu wrote:
> If disk have been deleted, we should return fail for ioctl
> BLKPG_DEL_PARTITION. Otherwise, the directory /sys/class/block
> may remain invalid symlinks file. The race as following:
> blkdev_open
> 				del_gendisk
> 				    disk->flags &= ~GENHD_FL_UP;
> 				    blk_drop_partitions
> blkpg_ioctl
>     bdev_add_partition
>     add_partition
>         device_add
> 	    device_add_class_symlinks
> ioctl may add_partition after del_gendisk() have tried to delete
> partitions. Then, symlinks file will be created.

Applied, thanks.

Jens Axboe

      parent reply	other threads:[~2021-07-01  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  2:32 Yufen Yu
2021-06-29  8:47 ` Yufen Yu
2021-07-01  1:39 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] block: check disk exist before trying to add partition' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).