From: Jens Axboe <axboe@kernel.dk>
To: Marcos Souza <marcos.souza.org@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blk-sysfs: Rework documention of __blk_release_queue
Date: Sun, 10 Feb 2019 08:50:53 -0700 [thread overview]
Message-ID: <9d1b596a-e5c6-6ad4-0a03-789bddb3d090@kernel.dk> (raw)
In-Reply-To: <CAH0vN5JF6p0B+uO2CQ-+Bv_cEtBRtWdpLJHD9mYAf3Ht2GncdA@mail.gmail.com>
On 2/10/19 8:44 AM, Marcos Souza wrote:
>
>
> On Sun, Feb 10, 2019, 13:23 Jens Axboe <axboe@kernel.dk <mailto:axboe@kernel.dk> wrote:
>
> On 2/9/19 11:34 AM, Marcos Paulo de Souza wrote:
> > Ping :)
> >
> > On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote:
> >> The Notes section of the comment was removed, because now
> >> blk_release_queue can only be executed from blk_cleanup_queue (being
> >> called when the q->kobj reaches zero), and also blk_init_queue was removed
> >> in a1ce35fa4985.
> >>
> >> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com <mailto:marcos.souza.org@gmail.com>>
> >> ---
> >> This is basically a v2 of https://lkml.org/lkml/2019/1/14/1098
> >>
> >> But, I tried to describe when this function is called, removing redundancies.
> >> Maybe it would be better placed in blk-core.c, where the q->kobj is initialized
> >> with blk_queue_ktype (which .release pointer points to blk_release_queue)?
> >>
> >> block/blk-sysfs.c | 19 +++++++------------
> >> 1 file changed, 7 insertions(+), 12 deletions(-)
> >>
> >> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> >> index 590d1ef2f961..d4dea9179fa6 100644
> >> --- a/block/blk-sysfs.c
> >> +++ b/block/blk-sysfs.c
> >> @@ -817,21 +817,16 @@ static void blk_free_queue_rcu(struct rcu_head *rcu_head)
> >> }
> >>
> >> /**
> >> - * __blk_release_queue - release a request queue when it is no longer needed
> >> + * __blk_release_queue - release a request queue
> >> * @work: pointer to the release_work member of the request queue to be released
> >> *
> >> * Description:
> >> - * blk_release_queue is the counterpart of blk_init_queue(). It should be
> >> - * called when a request queue is being released; typically when a block
> >> - * device is being de-registered. Its primary task it to free the queue
> >> - * itself.
> >> - *
> >> - * Notes:
> >> - * The low level driver must have finished any outstanding requests first
> >> - * via blk_cleanup_queue().
> >> - *
> >> - * Although blk_release_queue() may be called with preemption disabled,
> >> - * __blk_release_queue() may sleep.
> >> + * This function is called when a block device is being de-registered. The
>
> unregistered
>
> >> + * process of releasing a request queue starts with blk_cleanup_queue, which
> >> + * set the appropriate flags and the calls blk_put_queue, that decrements
>
> s/the/then
>
>
> Thanks foe the review. Do you want me to send a v2?
Yes please.
--
Jens Axboe
prev parent reply other threads:[~2019-02-10 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 1:11 [PATCH] blk-sysfs: Rework documention of __blk_release_queue Marcos Paulo de Souza
2019-02-09 18:34 ` Marcos Paulo de Souza
2019-02-10 15:23 ` Jens Axboe
[not found] ` <CAH0vN5JF6p0B+uO2CQ-+Bv_cEtBRtWdpLJHD9mYAf3Ht2GncdA@mail.gmail.com>
2019-02-10 15:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d1b596a-e5c6-6ad4-0a03-789bddb3d090@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).