From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6B3C2D0F0 for ; Mon, 30 Mar 2020 22:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9892920784 for ; Mon, 30 Mar 2020 22:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729197AbgC3W3U (ORCPT ); Mon, 30 Mar 2020 18:29:20 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44970 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728987AbgC3W3T (ORCPT ); Mon, 30 Mar 2020 18:29:19 -0400 Received: by mail-pl1-f194.google.com with SMTP id h11so7313058plr.11; Mon, 30 Mar 2020 15:29:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WxPMXDAVCMgxHw1lTLqOxkQSABPvO25tJYgztSXGdRM=; b=pCXJY3qsNjMextqdAE43C2SykSjwRMrgB+9yzyVP8JKoFCvqVmzdFsP03KFG3cFizM TCN0wlgD6Fl7SvYwpTvVD536gRgbCmQiY53mTXM/oHw4awoHwxSU2xsUeclkz71wUU36 MwyJ9GCyqDPkfGFPZB262GbZUPgnTyZWRZ1ap/r4aqfG/i7GiKncAJA/XxOsJqPhDGpF 6gYhXYTY3b+63YIRpr+hasatlFX6f0VDtVM0DfAEN3NYt7ud17K6YSqOibiegUvYOTy5 EF82jK45dEYOBQA3Qt9zfm1fNcFc0VqGwqncijh/Byi8zaNePEYybdmSzJyYNqeQY70b fl1g== X-Gm-Message-State: AGi0PuYN80jAcUWfA6d9cDJgN0JMRI4NRz5W2l3Y9JwFLlJPyhNWyiDf 6EBJIU5h0IvrWP9gpTRp7LM= X-Google-Smtp-Source: APiQypJralrCXkTvUqZ8tOFgwDSBNb+lshclmI2BB8i2ANNMt6B60pY4ruuxRWiAOkKs7816sqhnsw== X-Received: by 2002:a17:90a:240f:: with SMTP id h15mr351081pje.176.1585607358540; Mon, 30 Mar 2020 15:29:18 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:5408:f41a:5985:3059? ([2601:647:4000:d7:5408:f41a:5985:3059]) by smtp.gmail.com with ESMTPSA id y30sm11069017pff.67.2020.03.30.15.29.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2020 15:29:17 -0700 (PDT) Subject: Re: [PATCH v11 12/26] RDMA/rtrs: server: sysfs interface functions To: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org Cc: axboe@kernel.dk, hch@infradead.org, sagi@grimberg.me, leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca, danil.kipnis@cloud.ionos.com, rpenyaev@suse.de, pankaj.gupta@cloud.ionos.com References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com> <20200320121657.1165-13-jinpu.wang@cloud.ionos.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <9ecaaa54-9aa2-958e-e741-c908fee60a83@acm.org> Date: Mon, 30 Mar 2020 15:29:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200320121657.1165-13-jinpu.wang@cloud.ionos.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020-03-20 05:16, Jack Wang wrote: > +static struct kobj_type ktype = { > + .sysfs_ops = &kobj_sysfs_ops, > +}; It seems like a release method is missing here. Thanks, Bart.