Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Yufen Yu <yuyufen@huawei.com>
To: Jack Wang <jack.wang.usish@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
	Ming Lei <ming.lei@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Keith Busch <keith.busch@intel.com>,
	Bart Van Assche <bvanassche@acm.org>,
	stable <stable@vger.kernel.org>, <guoqing.jiang@cloud.ionos.com>,
	<jinpu.wang@cloud.ionos.com>
Subject: Re: [PATCH v4] block: fix null pointer dereference in blk_mq_rq_timed_out()
Date: Fri, 11 Oct 2019 11:16:08 +0800
Message-ID: <9f99de42-9edb-d7df-df8c-e994ada6613c@huawei.com> (raw)
In-Reply-To: <CA+res+QQtXD6phz=Ko-_n7eWVySrJA1kqgmMW3h3YUX+5RQ_7w@mail.gmail.com>



On 2019/10/9 16:26, Jack Wang wrote:
>
>> We got a null pointer deference BUG_ON in blk_mq_rq_timed_out()
>> as following:
>>
>> [  108.825472] BUG: kernel NULL pointer dereference, address: 0000000000000040
>> [  108.827059] PGD 0 P4D 0
>> [  108.827313] Oops: 0000 [#1] SMP PTI
>> [  108.827657] CPU: 6 PID: 198 Comm: kworker/6:1H Not tainted 5.3.0-rc8+ #431
>> [  108.829503] Workqueue: kblockd blk_mq_timeout_work
>> [  108.829913] RIP: 0010:blk_mq_check_expired+0x258/0x330
>> [  108.838191] Call Trace:
>> [  108.838406]  bt_iter+0x74/0x80
>> [  108.838665]  blk_mq_queue_tag_busy_iter+0x204/0x450
>> [  108.839074]  ? __switch_to_asm+0x34/0x70
>> [  108.839405]  ? blk_mq_stop_hw_queue+0x40/0x40
>> [  108.839823]  ? blk_mq_stop_hw_queue+0x40/0x40
>> [  108.840273]  ? syscall_return_via_sysret+0xf/0x7f
>> [  108.840732]  blk_mq_timeout_work+0x74/0x200
>> [  108.841151]  process_one_work+0x297/0x680
>> [  108.841550]  worker_thread+0x29c/0x6f0
>> [  108.841926]  ? rescuer_thread+0x580/0x580
>> [  108.842344]  kthread+0x16a/0x1a0
>> [  108.842666]  ? kthread_flush_work+0x170/0x170
>> [  108.843100]  ret_from_fork+0x35/0x40
>>
>> The bug is caused by the race between timeout handle and completion for
>> flush request.
>>
>> When timeout handle function blk_mq_rq_timed_out() try to read
>> 'req->q->mq_ops', the 'req' have completed and reinitiated by next
>> flush request, which would call blk_rq_init() to clear 'req' as 0.
>>
>> After commit 12f5b93145 ("blk-mq: Remove generation seqeunce"),
>> normal requests lifetime are protected by refcount. Until 'rq->ref'
>> drop to zero, the request can really be free. Thus, these requests
>> cannot been reused before timeout handle finish.
>>
>> However, flush request has defined .end_io and rq->end_io() is still
>> called even if 'rq->ref' doesn't drop to zero. After that, the 'flush_rq'
>> can be reused by the next flush request handle, resulting in null
>> pointer deference BUG ON.
>>
>> We fix this problem by covering flush request with 'rq->ref'.
>> If the refcount is not zero, flush_end_io() return and wait the
>> last holder recall it. To record the request status, we add a new
>> entry 'rq_status', which will be used in flush_end_io().
>>
>> Cc: Ming Lei <ming.lei@redhat.com>
>> Cc: Christoph Hellwig <hch@infradead.org>
>> Cc: Keith Busch <keith.busch@intel.com>
>> Cc: Bart Van Assche <bvanassche@acm.org>
>> Cc: stable@vger.kernel.org # v4.18+
>> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
>>
> Hi Yufen,
>
> Can you share your reproducer, I think the bug was there for long
> time, we hit it in kernel 4.4.
> We also need to fix it for older LTS kernel.
>
> Do you have an idea, how should we fix it for older LTS kernel?
>

I have reproduced the bug by increasing delay after doing memset()
in blk_rq_init() and before calling blk_mq_rq_timed_out() in 
blk_mq_check_expired().

To make sure the request will be timeout, I have also increase delay
for flush request after blk_mq_start_request() in virtio_queue_rq() for
my virtio disk. Then, we just issue a flush request for the disk by fio.
The BUG_ON will be triggered.

For LTS 4.4 or older kernel, the race between timeout handle and completion
for normal request have not yet resolved.
So, IMO, we should fix the bug first by merging commit 12f5b93145
("blk-mq: Remove generation seqeunce") and its related patches.

After that, this patch can also be merged.

Thanks,
Yufen


      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 12:20 Yufen Yu
2019-09-26 10:04 ` Jens Axboe
2019-09-26 13:52   ` Yufen Yu
2019-10-09  8:26 ` Jack Wang
2019-10-11  3:16   ` Yufen Yu [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f99de42-9edb-d7df-df8c-e994ada6613c@huawei.com \
    --to=yuyufen@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=guoqing.jiang@cloud.ionos.com \
    --cc=hch@infradead.org \
    --cc=jack.wang.usish@gmail.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox