linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritika Srivastava <RITIKA.SRIVASTAVA@ORACLE.COM>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits
Date: Wed, 26 Aug 2020 10:03:07 -0700	[thread overview]
Message-ID: <A746E97B-C886-4211-8A28-B3A4DDD1703C@ORACLE.COM> (raw)
In-Reply-To: <20200818194321.GA3271@infradead.org>

Hi Jens,

Can the following patches please be applied.

[PATCH 1/2] block: Return blk_status_t instead of errno codes
[PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits

Thanks,
Ritika

> On Aug 18, 2020, at 12:43 PM, Christoph Hellwig <hch@infradead.org> wrote:
> 
> On Tue, Aug 18, 2020 at 10:39:40AM -0700, Ritika Srivastava wrote:
>> If WRITE_ZERO/WRITE_SAME operation is not supported by the storage,
>> blk_cloned_rq_check_limits() will return IO error which will cause
>> device-mapper to fail the paths.
>> 
>> Instead, if the queue limit is set to 0, return BLK_STS_NOTSUPP.
>> BLK_STS_NOTSUPP will be ignored by device-mapper and will not fail the
>> paths.
>> 
>> Suggested-by: Martin K. Petersen <martin.petersen@oracle.com>
>> Signed-off-by: Ritika Srivastava <ritika.srivastava@oracle.com>
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2020-08-26 17:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 17:39 [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits Ritika Srivastava
2020-08-18 19:43 ` Christoph Hellwig
2020-08-26 17:03   ` Ritika Srivastava [this message]
2020-09-01 20:17 Return BLK_STS_NOTSUPP and blk_status_t from blk_cloned_rq_check_limits() Ritika Srivastava
2020-09-01 20:17 ` [PATCH v4 2/2] block: better deal with the delayed not supported case in blk_cloned_rq_check_limits Ritika Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A746E97B-C886-4211-8A28-B3A4DDD1703C@ORACLE.COM \
    --to=ritika.srivastava@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).