From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <Keith.Busch@wdc.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH v4 8/8] sd_zbc: clear zone resources for non-zoned case
Date: Thu, 28 Jan 2021 09:36:47 +0000 [thread overview]
Message-ID: <BL0PR04MB6514062937FF5BE302A27C8FE7BA9@BL0PR04MB6514.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210128092406.GA2607@lst.de
On 2021/01/28 18:24, Christoph Hellwig wrote:
> On Thu, Jan 28, 2021 at 01:47:33PM +0900, Damien Le Moal wrote:
>> For host-aware ZBC disk, setting the device zoned model to BLK_ZONED_HA
>> using blk_queue_set_zoned() in sd_read_block_characteristics() may
>> result in the block device effective zoned model to be "none"
>> (BLK_ZONED_NONE) if partitions are present on the device. In this case,
>> sd_zbc_read_zones() should not setup the zone related queue limits for
>> the disk so that the device limits and configuration is consistent with
>> a regular disk and resources not uselessly allocated (e.g. the zone
>> write pointer tracking array for zone append emulation).
>>
>> Furthermore, if the disk zoned model changes at run time due to the
>> creation of a partition by the user, the zone related resources can be
>> released.
>>
>> Fix both problems by introducing the function sd_zbc_clear_zone_info()
>> to reset the scsi disk zone information and free resources and by
>> returning early in sd_zbc_read_zones() for a block device that has a
>> zoned model equal to BLK_ZONED_NONE.
>
> So creating the partition doesn't even call into the driver, which
> means we'll leak the info for now. But I guess the next revalidate
> will simply clean it up, so it is not a major issue.
Exactly. But the leak is only for the sd level resources now.
blk_queue_set_zoned() cleans up everything else.
The super annoying thing is that deleting all partitions leaves that disk in
regular mode instead of returning it to zoned mode. Need to wait for a
revalidate or for a manual rescan for that to happen. I wonder if we should not
trigger a revalidate, always, to avoid that the user sees the device type
suddenly changing long after the partitions were deleted...
Adding such revalidate for partition creation would solve the "leak" problem (or
rather the lack of cleaning) too.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-01-28 9:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 4:47 [PATCH v4 0/8] block: add zone write granularity limit Damien Le Moal
2021-01-28 4:47 ` [PATCH v4 1/8] block: document zone_append_max_bytes attribute Damien Le Moal
2021-01-28 10:20 ` Johannes Thumshirn
2021-01-28 4:47 ` [PATCH v4 2/8] nvme: cleanup zone information initialization Damien Le Moal
2021-01-28 9:17 ` Christoph Hellwig
2021-01-28 9:27 ` Damien Le Moal
2021-01-28 9:32 ` Christoph Hellwig
2021-01-28 4:47 ` [PATCH v4 3/8] nullb: use blk_queue_set_zoned() to setup zoned devices Damien Le Moal
2021-01-28 5:12 ` Chaitanya Kulkarni
2021-01-28 9:17 ` Christoph Hellwig
2021-01-28 11:17 ` Johannes Thumshirn
2021-01-28 4:47 ` [PATCH v4 4/8] block: use blk_queue_set_zoned in add_partition() Damien Le Moal
2021-01-28 5:16 ` Chaitanya Kulkarni
2021-01-28 9:17 ` Christoph Hellwig
2021-01-28 11:28 ` Johannes Thumshirn
2021-01-28 4:47 ` [PATCH v4 5/8] block: introduce zone_write_granularity limit Damien Le Moal
2021-01-28 9:19 ` Christoph Hellwig
2021-01-28 11:32 ` Johannes Thumshirn
2021-02-05 2:54 ` Martin K. Petersen
2021-01-28 4:47 ` [PATCH v4 6/8] zonefs: use zone write granularity as block size Damien Le Moal
2021-01-28 5:17 ` Chaitanya Kulkarni
2021-01-28 11:33 ` Johannes Thumshirn
2021-01-28 4:47 ` [PATCH v4 7/8] block: introduce blk_queue_clear_zone_settings() Damien Le Moal
2021-01-28 5:26 ` Chaitanya Kulkarni
2021-01-28 9:21 ` Christoph Hellwig
2021-01-28 9:32 ` Damien Le Moal
2021-01-28 9:33 ` Christoph Hellwig
2021-01-28 11:43 ` Johannes Thumshirn
2021-01-28 4:47 ` [PATCH v4 8/8] sd_zbc: clear zone resources for non-zoned case Damien Le Moal
2021-01-28 5:38 ` Chaitanya Kulkarni
2021-01-28 5:40 ` Damien Le Moal
2021-01-28 9:24 ` Christoph Hellwig
2021-01-28 9:36 ` Damien Le Moal [this message]
2021-01-28 11:48 ` Johannes Thumshirn
2021-02-05 2:56 ` Martin K. Petersen
2021-02-04 8:47 ` [PATCH v4 0/8] block: add zone write granularity limit Damien Le Moal
2021-02-08 17:17 ` Christoph Hellwig
2021-02-10 14:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR04MB6514062937FF5BE302A27C8FE7BA9@BL0PR04MB6514.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Keith.Busch@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).