From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Hulk Robot <hulkci@huawei.com>, Jens Axboe <axboe@kernel.dk>,
Lauri Kasanen <cand@gmx.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH -next] n64: fix return value check in n64cart_probe()
Date: Tue, 23 Feb 2021 19:32:30 +0000 [thread overview]
Message-ID: <BYAPR04MB49653378C3288544F3B4B72686809@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210223140104.1743541-1-weiyongjun1@huawei.com
On 2/23/21 05:55, Wei Yongjun wrote:
> In case of error, the function devm_platform_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
prev parent reply other threads:[~2021-02-23 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:01 [PATCH -next] n64: fix return value check in n64cart_probe() Wei Yongjun
2021-02-23 14:56 ` Lauri Kasanen
2021-02-23 19:32 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB49653378C3288544F3B4B72686809@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=cand@gmx.com \
--cc=hulkci@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).