From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Wu Bo <wubo40@huawei.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"sagi@grimberg.me" <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH V15 4/5] nvmet: add Command Set Identifier support
Date: Fri, 11 Jun 2021 02:35:16 +0000 [thread overview]
Message-ID: <BYAPR04MB4965DAB9078B76AC9CACC8CA86349@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 923a0c0e-2f5f-e2f7-aa3b-b4feddd754b2@huawei.com
On 6/10/21 19:14, Wu Bo wrote:
>> case NVME_ID_CNS_CTRL:
>> - return nvmet_execute_identify_ctrl(req);
>> + switch (req->cmd->identify.csi) {
>> + case NVME_CSI_NVM:
>> + return nvmet_execute_identify_ctrl(req);
>> + }
> Is it missing to add the default branch here ?
>
maybe for the consistency
next prev parent reply other threads:[~2021-06-11 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 1:32 [PATCH V15 0/5] nvmet: add ZBD backened support Chaitanya Kulkarni
2021-06-10 1:32 ` [PATCH V15 1/5] block: export blk_next_bio() Chaitanya Kulkarni
2021-06-10 1:32 ` [PATCH V15 2/5] nvmet: add req cns error complete helper Chaitanya Kulkarni
2021-06-10 1:32 ` [PATCH V15 3/5] nvmet: add nvmet_req_bio put helper for backends Chaitanya Kulkarni
2021-06-10 1:32 ` [PATCH V15 4/5] nvmet: add Command Set Identifier support Chaitanya Kulkarni
2021-06-11 2:14 ` Wu Bo
2021-06-11 2:35 ` Chaitanya Kulkarni [this message]
2021-06-10 1:32 ` [PATCH V15 5/5] nvmet: add ZBD over ZNS backend support Chaitanya Kulkarni
2021-06-15 16:25 ` [PATCH V15 0/5] nvmet: add ZBD backened support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965DAB9078B76AC9CACC8CA86349@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).