From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Christoph Hellwig <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: remove the REQ_NOWAIT_INLINE flag
Date: Tue, 5 May 2020 06:44:05 +0000 [thread overview]
Message-ID: <BYAPR04MB4965EEE9C5F85B78A2CC7D2286A70@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200504161005.2841033-1-hch@lst.de
On 5/4/20 9:10 AM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> include/linux/blk_types.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 90895d594e647..7443e474cdad5 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -323,7 +323,6 @@ enum req_flag_bits {
> __REQ_RAHEAD, /* read ahead, can fail anytime */
> __REQ_BACKGROUND, /* background IO */
> __REQ_NOWAIT, /* Don't wait if request will block */
> - __REQ_NOWAIT_INLINE, /* Return would-block error inline */
> /*
> * When a shared kthread needs to issue a bio for a cgroup, doing
> * so synchronously can lead to priority inversions as the kthread
> @@ -358,7 +357,6 @@ enum req_flag_bits {
> #define REQ_RAHEAD (1ULL << __REQ_RAHEAD)
> #define REQ_BACKGROUND (1ULL << __REQ_BACKGROUND)
> #define REQ_NOWAIT (1ULL << __REQ_NOWAIT)
> -#define REQ_NOWAIT_INLINE (1ULL << __REQ_NOWAIT_INLINE)
> #define REQ_CGROUP_PUNT (1ULL << __REQ_CGROUP_PUNT)
>
> #define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP)
> -- 2.26.2
Looks good to me.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2020-05-05 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 16:10 [PATCH] block: remove the REQ_NOWAIT_INLINE flag Christoph Hellwig
2020-05-05 6:44 ` Chaitanya Kulkarni [this message]
2020-05-16 15:51 ` Christoph Hellwig
2020-05-16 20:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965EEE9C5F85B78A2CC7D2286A70@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).