From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Paolo Valente <paolo.valente@linaro.org>, Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bfq-iosched@googlegroups.com" <bfq-iosched@googlegroups.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
Tejun Heo <tj@kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Angelo Ruocco <angeloruocco90@gmail.com>
Subject: Re: [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames
Date: Tue, 17 Sep 2019 21:04:52 +0000 [thread overview]
Message-ID: <BYAPR04MB57492FC0194EFB7506147533868F0@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190917165148.19146-3-paolo.valente@linaro.org
Looks good to me.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 09/17/2019 09:52 AM, Paolo Valente wrote:
> From: Angelo Ruocco<angeloruocco90@gmail.com>
>
> When bfq was merged into mainline, there were two I/O schedulers that
> implemented the proportional-share policy: bfq for blk-mq and cfq for
> legacy blk. bfq's interface files in the blkio/io controller have the
> same names as cfq. But the cgroups interface doesn't allow two
> entities to use the same name for their files, so for bfq we had to
> prepend the "bfq" prefix to each of its files. However no legacy code
> uses these modified file names. This naming also causes confusion, as,
> e.g., in [1].
>
> Now cfq has gone with legacy blk, so there is no need any longer for
> these prefixes in (the never used) bfq names. In view of this fact, this
> commit removes these prefixes, thereby enabling legacy code to truly
> use the proportional share policy in blk-mq.
>
> [1]https://github.com/systemd/systemd/issues/7057
>
> Signed-off-by: Angelo Ruocco<angeloruocco90@gmail.com>
> Signed-off-by: Paolo Valente<paolo.valente@linaro.org>
next prev parent reply other threads:[~2019-09-17 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 16:51 [PATCH 0/2 block/for-next] block, blkcg, bfq: make bfq disable iocost and delete bfq prefix from cgroup filenames Paolo Valente
2019-09-17 16:51 ` [PATCH 1/2] blkcg: Make bfq disable iocost when enabled Paolo Valente
2019-09-17 16:51 ` [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames Paolo Valente
2019-09-17 21:04 ` Chaitanya Kulkarni [this message]
2019-09-17 21:32 ` Tejun Heo
2019-09-18 5:18 ` Paolo Valente
2019-09-18 15:19 ` Tejun Heo
2019-09-18 16:19 ` Paolo Valente
2019-09-20 6:58 ` Paolo Valente
2019-09-20 13:05 ` Jens Axboe
2019-09-21 6:55 ` Paolo Valente
2019-09-18 6:09 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57492FC0194EFB7506147533868F0@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=angeloruocco90@gmail.com \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=cgroups@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).