From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F272DC07E9B for ; Wed, 21 Jul 2021 07:56:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD70761019 for ; Wed, 21 Jul 2021 07:56:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235929AbhGUHPi (ORCPT ); Wed, 21 Jul 2021 03:15:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235853AbhGUHPh (ORCPT ); Wed, 21 Jul 2021 03:15:37 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C42AC061574 for ; Wed, 21 Jul 2021 00:56:11 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id c12so1125735wrt.3 for ; Wed, 21 Jul 2021 00:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8w6x8b/7oISblxGUWEIo1tWz0WRfvQ9VyhhiZejv2vo=; b=Tt1MCuMlpx25tAZ8kaDzDLvA9Bmyxtfro3AOH0567K+PGiryJKOZqPkgUoCxkx9Wfe wLjkrzQx9E3vsMqPu8cOL8uHhMYvhjmZaVhwMknK8+bQJe+rQbHypIC8R0YUJKUaEtuB jTghtKK5RgJadYVO81tbqpvrNPX6m8OPZdbgFa6bZVM/1+1tIyuy2h+HZn7PDRkKjXLq 2sspURuBgsFMvztK08fedY+lJ9LE2+Q9U6bzHREF38s6EIETmLDxc/E1hRma5I6YOBEU z/rveNG3ui2qG+zKiKcurGLjP43SoHnHud/M6KE2Yse9HcxU7eM4S4p40TboRrdMcsQv ZIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8w6x8b/7oISblxGUWEIo1tWz0WRfvQ9VyhhiZejv2vo=; b=sTGSmUzC1ovhANfOnZvDtIVlzTwcfLMJIhUe3UpOH2jBrvVGpM2Em/A1yJ0q5+BJAB +QCiB1RVGkBr1OeqbGWwb+IhN70bw3er9MGZQmkoyDMQM5Ajtg1hY9fyy2EtusTJb8+Y NLhHTtyzt1qciC1mmFRU8USAO4gkvmeYuPMaq2/I9yAMQreAv68lO2vydcoKiOOSXe4c pIml33ZPYHBsxvIiW/a4WY44WjzpdGkYWTkkzz+q0YLe79POAGMhYzHueWbpYXKXxIZV 2ZFQ0Xl3XohCk/snp3IdNBn2JYpQrCPMkvnVjysOk+Kp/jobWxxyG1nt+OOpphiDjs0R WU/g== X-Gm-Message-State: AOAM530jTevqMtSBomO5U0vzXuSpCaMnWL8+OiTW8BGe7/8q8/Cn6rzo Byqw8QYi9wpTEUhkJASCKoSrJA== X-Google-Smtp-Source: ABdhPJzj097tjUzSS6tAEMTQjHX81v616+ZPhb3BSxHkaWVSqwV5SnLuiMTEp4iXQ6qWqIFyJJi6/w== X-Received: by 2002:a5d:46d1:: with SMTP id g17mr41675852wrs.2.1626854170169; Wed, 21 Jul 2021 00:56:10 -0700 (PDT) Received: from wifi-122-dhcprange-122-230.wifi.unimo.it (wifi-122-dhcprange-122-230.wifi.unimo.it. [155.185.122.230]) by smtp.gmail.com with ESMTPSA id n18sm25133005wrt.89.2021.07.21.00.56.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jul 2021 00:56:09 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] block/bfq: the delta_from_first should be ns rather than us From: Paolo Valente In-Reply-To: <20210721063047.92122-1-liubaozhu@uniontech.com> Date: Wed, 21 Jul 2021 09:56:12 +0200 Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210721063047.92122-1-liubaozhu@uniontech.com> To: liubaozhu X-Mailer: Apple Mail (2.3445.104.11) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org [RESENDING ...] > Il giorno 21 lug 2021, alle ore 08:30, liubaozhu = ha scritto: >=20 > In the block/bfq-iosched.c,the function bfq_update_peak_rate(), > bfqd->delta_from_first =3D now_ns - bfqd->first_dispatch, > according to the subtraction operation here,now_ns is ns, > and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should = be ns. >=20 Correct! Acked-by: Paolo Valente Thank you, Paolo > Signed-off-by: liubaozhu > --- > block/bfq-iosched.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h > index 99c2a3cb0..7cf4fc8c3 100644 > --- a/block/bfq-iosched.h > +++ b/block/bfq-iosched.h > @@ -632,7 +632,7 @@ struct bfq_data { > u64 tot_sectors_dispatched; > /* max rq size seen during current observation interval = (sectors) */ > u32 last_rq_max_size; > - /* time elapsed from first dispatch in current observ. interval = (us) */ > + /* time elapsed from first dispatch in current observ. interval = (ns) */ > u64 delta_from_first; > /* > * Current estimate of the device peak rate, measured in > --=20 > 2.20.1 >=20 >=20 >=20