From: Yuanyuan Zhong <yzhong@purestorage.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq()
Date: Mon, 19 Apr 2021 11:20:39 -0700 [thread overview]
Message-ID: <CA+AMecF6CODiR3sze-PAjhJ37YsjEGzM4CdKSBHxVUCMi=KwvA@mail.gmail.com> (raw)
In-Reply-To: <20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com>
On Mon, Apr 19, 2021 at 10:48 AM Keith Busch <kbusch@kernel.org> wrote:
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b57157106cac..a0fb9ad132af 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -949,6 +949,9 @@ static void nvme_end_sync_rq(struct request *rq, blk_status_t error)
> struct completion *waiting = rq->end_io_data;
>
> rq->end_io_data = NULL;
> + if (error && !nvme_req(rq)->status)
Is setting nvme_req(rq)->status for each error return in ->queue_rq()
going to gradually roll out, and eventually skipping the fallback here?
> + nvme_req(rq)->status = blk_status_to_errno(error);
Casting int negative errno to u16 will get 0xfff., meaning NVME_SC_DNR is set.
Is that always right?
--
Regards,
Yuanyuan Zhong
next prev parent reply other threads:[~2021-04-19 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 16:53 [PATCH 1/2] block: return errors from blk_execute_rq() Keith Busch
2021-04-16 16:53 ` [PATCH 2/2] nvme: use return value " Keith Busch
2021-04-16 17:12 ` Yuanyuan Zhong
2021-04-16 17:17 ` Keith Busch
2021-04-19 7:16 ` Christoph Hellwig
2021-04-19 15:14 ` Keith Busch
2021-04-19 17:27 ` Yuanyuan Zhong
2021-04-19 17:48 ` Keith Busch
2021-04-19 18:20 ` Yuanyuan Zhong [this message]
2021-04-18 4:17 ` Chaitanya Kulkarni
2021-04-18 4:13 ` [PATCH 1/2] block: return errors " Chaitanya Kulkarni
2021-04-17 2:04 [PATCH 2/2] nvme: use return value " Casey Chen
2021-04-17 2:39 ` Keith Busch
2021-04-23 21:57 [PATCH 1/2] block: return errors " Keith Busch
2021-04-23 21:58 ` [PATCH 2/2] nvme: use return value " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+AMecF6CODiR3sze-PAjhJ37YsjEGzM4CdKSBHxVUCMi=KwvA@mail.gmail.com' \
--to=yzhong@purestorage.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).