From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7873C433ED for ; Mon, 19 Apr 2021 18:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 649E36127C for ; Mon, 19 Apr 2021 18:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240156AbhDSSVX (ORCPT ); Mon, 19 Apr 2021 14:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240096AbhDSSVW (ORCPT ); Mon, 19 Apr 2021 14:21:22 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52935C06174A for ; Mon, 19 Apr 2021 11:20:50 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id c8-20020a9d78480000b0290289e9d1b7bcso19397035otm.4 for ; Mon, 19 Apr 2021 11:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zXRcipxB0g/YkNP+zUJKHMJKNLy+Z2cSEPqRQaNlD0o=; b=WX2T8vXeEesLKvdJysC3KPGA0tjCwe1DMYOc+PqlJBBN3O+pqldLvIuATn4UIegM0/ nXqj6b5v+WkM622NPydhWJ0RfVKxFta+RZm+L+tseRtTLLXmrzX1p3LdGkLmpo3qW9BR 0RLs8QcgFoVE1FcfPjid/R+fI+7WDZtSn0s7M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zXRcipxB0g/YkNP+zUJKHMJKNLy+Z2cSEPqRQaNlD0o=; b=B20hZlJ6Ibhl6fpNlCXNy//h6z0hUvMufwd9wB5NX6PModQD957O9n/oLOlM8a1bd1 aSEA8iLYJ6iyF6mbxq+t0rdwJ+yQaGO0WPYkyOyOQVXy+jbttc9Ez3+pfxqe0LhHBkjy J5EomV+Klgo8TfG9LYN+2ek0+pp749XOqiACHpIYHiKgKnk04Q8+XqtBPGiWEKmTkzgf CX+VKTiphgskU7EKH90zpStKD43sQ7eM2bo0/qgihEIPEmePIDJXVR74PREd06OX0jEc 4B+8CsCE4EzEvQRQnrlQOf/eDG4vSNeZqzEfsTukZ+O4ODrM+UdUUlFMFkuw0BtXy7B4 5zBw== X-Gm-Message-State: AOAM530yLEHIYhsAkxtFCmvqp7+buCzQfu4fgipA/MSPY07rVgqO+Z35 6g71PrvOzZvStKn8Rrra3VYZMpBif1JaeZ/s9oDWwg== X-Google-Smtp-Source: ABdhPJyRvI19wiTwpBH09wdf8iIumYNu5PFfQCGk4jAyQyZoJ9fpX/fhd4owoBzG8SbHmVU2e34zWBY//YIdNnHKvvw= X-Received: by 2002:a9d:7a53:: with SMTP id z19mr15247923otm.40.1618856449368; Mon, 19 Apr 2021 11:20:49 -0700 (PDT) MIME-Version: 1.0 References: <20210416165353.3088547-1-kbusch@kernel.org> <20210416165353.3088547-2-kbusch@kernel.org> <20210416171735.GA32082@redsun51.ssa.fujisawa.hgst.com> <20210419071605.GA19658@lst.de> <20210419151437.GA12999@redsun51.ssa.fujisawa.hgst.com> <20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com> In-Reply-To: <20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com> From: Yuanyuan Zhong Date: Mon, 19 Apr 2021 11:20:39 -0700 Message-ID: Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq() To: Keith Busch Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@kernel.dk, linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Apr 19, 2021 at 10:48 AM Keith Busch wrote: > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index b57157106cac..a0fb9ad132af 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -949,6 +949,9 @@ static void nvme_end_sync_rq(struct request *rq, blk_status_t error) > struct completion *waiting = rq->end_io_data; > > rq->end_io_data = NULL; > + if (error && !nvme_req(rq)->status) Is setting nvme_req(rq)->status for each error return in ->queue_rq() going to gradually roll out, and eventually skipping the fallback here? > + nvme_req(rq)->status = blk_status_to_errno(error); Casting int negative errno to u16 will get 0xfff., meaning NVME_SC_DNR is set. Is that always right? -- Regards, Yuanyuan Zhong