From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0F9C433E1 for ; Thu, 28 May 2020 16:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B95421532 for ; Thu, 28 May 2020 16:17:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dnY861HI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404966AbgE1QRS (ORCPT ); Thu, 28 May 2020 12:17:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404906AbgE1QRQ (ORCPT ); Thu, 28 May 2020 12:17:16 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2344C08C5C9 for ; Thu, 28 May 2020 09:17:14 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id 202so16907590lfe.5 for ; Thu, 28 May 2020 09:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IuyHwLJRnB6jxTc1IB7c0ys/rrbHpiCHBZYkZOd5+aA=; b=dnY861HISlW7Skc3gzpG3vW0s3QiWx9O4snM0Q63YTXMKM+DTDIREHzF4vRDxhIvbZ dYi7yQdeWR7/U7kdlDUHwOi9DdY7WbtDafHbadPk2OPyvMhIIkEiiUHeUss1TwcHy759 AkF2Q3ZVo/VG5Bdc4OEnX9FsUtb9Iw0ZFZ7YKTkSRlM9J0Gonu/ZDOEK5W9Y3RZ86gJk S1HLfVmE5rjKgkr2zLBllzghwb3k4F7KnbS94qnb1iZAADxYXmu+D8Da7yx7DAEi6qD0 X7sm5OjbS/W1CtcsJY4DpGOA0rwpitIt381IGnI44rO6i4hfyMb9laFfBPVIGGQELoEg Iv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IuyHwLJRnB6jxTc1IB7c0ys/rrbHpiCHBZYkZOd5+aA=; b=hmxmUJq2LD9Xr1Fb5TUvytkx7w7Zk6RHPsxxfCwh+ytdbUH3c4hUSiD5tg4ISwpObl oIt7ZyPXttmV1lyDMdFEP+UXRM8XxJifnGx18QCuHAUPSlxB2PaVUaXKaiXod89NrhHD N22twoDQWORmjfLgA5/xQ7gVRpgItHNOe4CY3QZDXodbOIUxXZUV4t0pUviZcL7LnxMq IKNvuR9H3DbrbTIZVPY2utxQgJQWk3N0P27Tskv2DykftYduDQV2HEDkpa1CAU7d2a62 bE5Y4pV6bz7JyI21C+SGMSzls+624DE4Sfj8siT2s05B/pfTcchfp1tOFUdrKLSdEX19 zaug== X-Gm-Message-State: AOAM5333tBL23sYmD+d9ObLFFdncs508Ykuh42nCZKa1pGHRq3Cq59xY 5BEBzVbgUC6BfHD35FCDemSzQ3LKBY/kZ+l32FUEow== X-Google-Smtp-Source: ABdhPJzEYvmxkKtNlYwKn0L9QLyYj9aEx1L7dHIVoXaEJGqWJSEwrWbMRGZQUlzYp/hC+LakUnqJ3RfWneyXxhcdcOs= X-Received: by 2002:a05:6512:533:: with SMTP id o19mr2029203lfc.6.1590682632866; Thu, 28 May 2020 09:17:12 -0700 (PDT) MIME-Version: 1.0 References: <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200528150310.GG27484@dhcp22.suse.cz> In-Reply-To: <20200528150310.GG27484@dhcp22.suse.cz> From: Naresh Kamboju Date: Thu, 28 May 2020 21:47:00 +0530 Message-ID: Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page To: Michal Hocko , Yafang Shao Cc: Chris Down , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , "Theodore Ts'o" , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, 28 May 2020 at 20:33, Michal Hocko wrote: > > On Fri 22-05-20 02:23:09, Naresh Kamboju wrote: > > My apology ! > > As per the test results history this problem started happening from > > Bad : next-20200430 (still reproducible on next-20200519) > > Good : next-20200429 > > > > The git tree / tag used for testing is from linux next-20200430 tag and reverted > > following three patches and oom-killer problem fixed. > > > > Revert "mm, memcg: avoid stale protection values when cgroup is above > > protection" > > Revert "mm, memcg: decouple e{low,min} state mutations from protectinn checks" > > Revert "mm-memcg-decouple-elowmin-state-mutations-from-protection-checks-fix" > > The discussion has fragmented and I got lost TBH. > In http://lkml.kernel.org/r/CA+G9fYuDWGZx50UpD+WcsDeHX9vi3hpksvBAWbMgRZadb0Pkww@mail.gmail.com > you have said that none of the added tracing output has triggered. Does > this still hold? Because I still have a hard time to understand how > those three patches could have the observed effects. On the other email thread [1] this issue is concluded. Yafang wrote on May 22 2020, Regarding the root cause, my guess is it makes a similar mistake that I tried to fix in the previous patch that the direct reclaimer read a stale protection value. But I don't think it is worth to add another fix. The best way is to revert this commit. [1] [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks https://lore.kernel.org/linux-mm/CALOAHbArZ3NsuR3mCnx_kbSF8ktpjhUF2kaaTa7Mb7ocJajsQg@mail.gmail.com/ - Naresh > -- > Michal Hocko > SUSE Labs