From: Weiping Zhang <zwp10758@gmail.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
mpatocka@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v5 0/2] fix inaccurate io_ticks
Date: Tue, 17 Nov 2020 12:59:46 +0800 [thread overview]
Message-ID: <CAA70yB4G_1jHYRyVsf_mhHQA-_mGXzaZ6n4Bgtq9n-x1_Yz4rg@mail.gmail.com> (raw)
In-Reply-To: <20201117032756.GE56247@T590>
On Tue, Nov 17, 2020 at 11:28 AM Ming Lei <ming.lei@redhat.com> wrote:
>
> On Tue, Nov 17, 2020 at 11:01:49AM +0800, Weiping Zhang wrote:
> > Hi Jens,
> >
> > Ping
>
> Hello Weiping,
>
> Not sure we have to fix this issue, and adding blk_mq_queue_inflight()
> back to IO path brings cost which turns out to be visible, and I did
> get soft lockup report on Azure NVMe because of this kind of cost.
>
Have you test v5, this patch is different from v1, the v1 gets
inflight for each IO,
v5 has changed to get inflight every jiffer.
If for v5, can we reproduce it on null_blk ?
> BTW, suppose the io accounting issue needs to be fixed, just wondering
> why not simply revert 5b18b5a73760 ("block: delete part_round_stats and
> switch to less precise counting"), and the original way had been worked
> for decades.
>
This patch is more better than before, it will break early when find there is
inflight io on any cpu, for the worst case(the io in running on the last cpu),
it iterates all cpus.
>
> Thanks,
> Ming
>
next prev parent reply other threads:[~2020-11-17 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 4:54 [PATCH v5 0/2] fix inaccurate io_ticks Weiping Zhang
2020-11-04 3:26 ` Weiping Zhang
2020-11-17 3:01 ` Weiping Zhang
2020-11-17 3:27 ` Ming Lei
2020-11-17 4:59 ` Weiping Zhang [this message]
2020-11-17 7:40 ` Ming Lei
2020-11-18 5:55 ` Weiping Zhang
2020-11-26 11:23 ` Weiping Zhang
2020-12-17 17:03 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA70yB4G_1jHYRyVsf_mhHQA-_mGXzaZ6n4Bgtq9n-x1_Yz4rg@mail.gmail.com \
--to=zwp10758@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).