linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weiping Zhang <zwp10758@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
	linux-block@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/3] bio: track timestamp of submitting bio the disk driver
Date: Tue, 31 Mar 2020 16:45:33 +0800	[thread overview]
Message-ID: <CAA70yB5cWESKW600Lwoi8toPaiDtOVH53P8GSou6uukmX5mvgQ@mail.gmail.com> (raw)
In-Reply-To: <20200331082505.GA14655@infradead.org>

Christoph Hellwig <hch@infradead.org> 于2020年3月31日周二 下午4:25写道：
>
> On Fri, Mar 27, 2020 at 02:28:59PM +0800, Weiping Zhang wrote:
> > Change-Id: Ibb9caf20616f83e111113ab5c824c05930c0e523
> > Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
>
> This needs a commit description and loose the weird change id.
>
OK, I rewirte commit description, it record the timestamp of issue bio
to the disk driver,
then we can get the delta time in rq_qos_done_bio. It's same as the D2C time
of blktrace.
> I also think oyu need to fins a way to not bloat the bio even more,
> cgroup is a really bad offender for bio size.
struct request {
    u64 io_start_time_ns;
also record this timestamp, I'll check if we can use it.

Thanks a lot

  reply	other threads:[~2020-03-31  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  6:28 [RFC PATCH v2 2/3] bio: track timestamp of submitting bio the disk driver Weiping Zhang
2020-03-31  8:25 ` Christoph Hellwig
2020-03-31  8:45   ` Weiping Zhang [this message]
2020-03-31  9:16     ` Christoph Hellwig
2020-03-31 10:56       ` Weiping Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA70yB5cWESKW600Lwoi8toPaiDtOVH53P8GSou6uukmX5mvgQ@mail.gmail.com \
    --to=zwp10758@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).