From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2B6C43331 for ; Thu, 26 Mar 2020 16:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A01B320848 for ; Thu, 26 Mar 2020 16:27:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uXKE2b7w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgCZQ1Z (ORCPT ); Thu, 26 Mar 2020 12:27:25 -0400 Received: from mail-lf1-f44.google.com ([209.85.167.44]:45179 "EHLO mail-lf1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbgCZQ1Z (ORCPT ); Thu, 26 Mar 2020 12:27:25 -0400 Received: by mail-lf1-f44.google.com with SMTP id v4so5346973lfo.12; Thu, 26 Mar 2020 09:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YvH8nAkRIhWjmEV+9kX4eoO50WVDe3LtRQC8pQNa05A=; b=uXKE2b7wkmnzI5GmZPrvAYbzQk2P/+sAOvmPrBZOw01lpLMbSeUUvFG8iT08TejXTm gVXNXk8ONo3VzqGk/RUq2FhPVbRS/WwuC3oH8al9lQEZPxR90XFMVcK+qjwpj41NXL3t A81Nej2jZkdxVL4fTPmJ9dXzTUjzPx2NXsAIlJ5FviAVgZ3ErTGm94NgWQxfTmuwVYaW N63LyOTACRCginyM8Uqlv4OS9bTm/aFqgPMb9NoKEhoWPszciYQxgIJpvUMS82bL9qAP ifCyacieEbveW/htPDeOtpva+IQKQN0Fpyqj+XqsMSeMR4btAaAoMo9yAMDXLwCFQKFr mi/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YvH8nAkRIhWjmEV+9kX4eoO50WVDe3LtRQC8pQNa05A=; b=Wb6pIGdsMCcKhAOtYkliiMi6eSOQyx3oRpwx2bS/c2cHSklggjry2MX/Wj2vgg7sNk OEPt2Q2Ri16d+wG/9+vYYOf+XTzS9cDOX1yp3cqzn2MFkB7OJNCsKH7u5ycyE4rfphNT LNnITG/pXl2qOH21+8r6j/NMcThaw8HOW0MLMGsnwzxwaMYaFZkSZdFa6VT44WlCQqRN nNu68Z9MCYyH00hAJK0na13oRvghM3HvsaLS+7dVP0SjlUn/FhZbQgSY6u6OkdVWNZpt ZVJzi8yy1sLMSzLTNF8PfnswxjfmXQRsIcOkRa40oWI5B72NThqJ8g6QCv33p5VaHz4T NoyA== X-Gm-Message-State: ANhLgQ1ROobK+T2z6Hwv9jz9uQFYpFjA7RN2Cr9drvnWDeVGuVi1pHrh 1Xp2uWPrcuG5n4ITQJXYGFbflomXnpXgb4OZdfgMd4Pi X-Google-Smtp-Source: ADFU+vu94rttJ1jdk65LzSuZJ59m1noymI2fxV6Tq7r9N1fgkW8O2Cbyxoebzj1IrkbB14CXm5WIIWHtiEzQpQXRtTk= X-Received: by 2002:a19:be11:: with SMTP id o17mr6198870lff.168.1585240042693; Thu, 26 Mar 2020 09:27:22 -0700 (PDT) MIME-Version: 1.0 References: <20200324182725.GG162390@mtj.duckdns.org> <20200325141236.GJ162390@mtj.duckdns.org> <20200326161328.GN162390@mtj.duckdns.org> In-Reply-To: <20200326161328.GN162390@mtj.duckdns.org> From: Weiping Zhang Date: Fri, 27 Mar 2020 00:27:11 +0800 Message-ID: Subject: Re: [RFC 0/3] blkcg: add blk-iotrack To: Tejun Heo Cc: Jens Axboe , linux-block@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Tejun Heo =E4=BA=8E2020=E5=B9=B43=E6=9C=8827=E6=97=A5=E5=91= =A8=E4=BA=94 =E4=B8=8A=E5=8D=8812:15=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, Mar 26, 2020 at 11:08:45PM +0800, Weiping Zhang wrote: > > But iocost_test1 cannot get 8/(8+1) iops, and the total disk iops > > is 737559 < 79388, even I change rrandiops=3D637000. > > iocost needs QoS targets set especially for deep queue devcies. W/o QoS t= argets, > it only throttles when QD is saturated, which might not happen at all dep= ending > on fio job params. > > Can you try with sth like the following in io.cost.qos? > > 259:0 enable=3D1 ctrl=3Duser rpct=3D95.00 rlat=3D5000 wpct=3D50.00 wlat= =3D10000 > > In case you see significant bw loss, step up the r/wlat params. > OK, I'll try it. I really appreciate that if you help review blk-iotrack.c, or just drop io.iotrakc.stat and append these statistics to the io.stat? I think these metrics is usefu= ll, and it just extend io.stat output. Thanks a ton