linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Lukas Prediger <lumip@lumip.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection
Date: Sat, 11 Sep 2021 12:00:27 +0100	[thread overview]
Message-ID: <CAA=Fs0mEprM0hErRY-kw7bOVqEw3o6X=--OixQ=_fNXdV_-QGQ@mail.gmail.com> (raw)
In-Reply-To: <e3efb5ea-0884-c02a-cb81-408ec421463d@infradead.org>

On Fri, 10 Sept 2021 at 22:41, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi Lukas,
>
> Just a minor nit:
>
> On 9/10/21 2:16 PM, Lukas Prediger wrote:
> > +#define MEDIA_CHANGED_FLAG   0x1     /* Last detected media change was more \
> > +                                      * recent than last_media_change set by\
> > +                                      * caller.                             \
> > +                                      */
>
> Drop the "continuation" backslashes.
> They are not needed.
>
> thanks.
> --
> ~Randy
>

Dear Lukas,

Happy to take these out for you and save you resubmitting.
I'm very happy with patch anyway. Once I hear back from
you I'll send onto Jens with my approval after one final test :-)

Thanks again for the code.

Regards,
Phil

  reply	other threads:[~2021-09-11 11:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 21:16 [PATCH v3] drivers/cdrom: improved ioctl for media change detection Lukas Prediger
2021-09-10 21:41 ` Randy Dunlap
2021-09-11 11:00   ` Phillip Potter [this message]
2021-09-11 17:48     ` Lukas Prediger
2021-09-12 18:04       ` Phillip Potter
2021-09-12 19:12         ` Lukas Prediger
2021-09-13  7:50           ` Phillip Potter
2021-10-06 20:52           ` Randy Dunlap
2021-10-07 23:04             ` Phillip Potter
2021-09-13 23:09 Phillip Potter
2021-09-15  2:05 ` Jens Axboe
2021-09-16 23:07   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA=Fs0mEprM0hErRY-kw7bOVqEw3o6X=--OixQ=_fNXdV_-QGQ@mail.gmail.com' \
    --to=phil@philpotter.co.uk \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumip@lumip.de \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).