From: Martijn Coenen <maco@android.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
kernel-team@android.com, Narayan Kamath <narayan@google.com>,
Dario Freni <dariofreni@google.com>,
Nikita Ioffe <ioffe@google.com>, Jiyong Park <jiyong@google.com>,
Martijn Coenen <maco@google.com>
Subject: Re: [PATCH] RFC: loop: Avoid calling blk_mq_freeze_queue() when possible.
Date: Thu, 15 Aug 2019 21:08:36 +0200 [thread overview]
Message-ID: <CAB0TPYEbHeTqd2ZrOyMSMbV+g7r0HMTt2GSpUrRZxM8XsNPi3Q@mail.gmail.com> (raw)
In-Reply-To: <CACVXFVP0JrpUgterqHs5bvCQn7L9a-XrjDCD3BmQOLe+rgC1KQ@mail.gmail.com>
On Thu, Aug 15, 2019 at 6:34 PM Ming Lei <tom.leiming@gmail.com> wrote:
> If nothing will change, why does the userspace bother to send
> SET_STATUS?
We don't change transfer, but we do change the offset and sizelimit.
In our specific case, we know there won't be any I/O from userspace at
this point; so from that point of view the freeze wouldn't be
necessary. But I'm not sure how we can make loop aware of that in a
safe way. Ideally we'd just have a way of completely configuring a
loop device before starting the block request queue, but that seems
like a pretty big change.
Martijn
>
>
> Thanks,
> Ming Lei
next prev parent reply other threads:[~2019-08-15 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:32 [PATCH] RFC: loop: Avoid calling blk_mq_freeze_queue() when possible Martijn Coenen
2019-08-14 11:33 ` Ming Lei
2019-08-14 11:38 ` Martijn Coenen
2019-08-14 11:46 ` Ming Lei
2019-08-15 14:57 ` Martijn Coenen
2019-08-15 16:34 ` Ming Lei
2019-08-15 19:08 ` Martijn Coenen [this message]
2019-08-19 9:06 ` Martijn Coenen
2019-08-19 9:26 ` Martijn Coenen
2019-08-14 15:29 ` Bart Van Assche
2019-08-15 14:49 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB0TPYEbHeTqd2ZrOyMSMbV+g7r0HMTt2GSpUrRZxM8XsNPi3Q@mail.gmail.com \
--to=maco@android.com \
--cc=axboe@kernel.dk \
--cc=dariofreni@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=ioffe@google.com \
--cc=jiyong@google.com \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=ming.lei@redhat.com \
--cc=narayan@google.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).