From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D06C47253 for ; Fri, 1 May 2020 11:33:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAC5C20757 for ; Fri, 1 May 2020 11:33:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="u2Fn21QM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728659AbgEALd0 (ORCPT ); Fri, 1 May 2020 07:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728581AbgEALdZ (ORCPT ); Fri, 1 May 2020 07:33:25 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8A61C061A0C for ; Fri, 1 May 2020 04:33:23 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id f18so2299146lja.13 for ; Fri, 01 May 2020 04:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GLXTIf6sR5xPtNtzDzFOIjNOdFUZv31CNDN3CIrYk74=; b=u2Fn21QMaMPaZhF3+p+phpGjItMvJ1fijPvTZnhWnBQ3Kl2NkKZ5DUcXIzboWaIEpq PHc7d76JBxNUX5u/aYisCd6toonq3zSOF/ex2HXvg3IoiL8y/yh4H2s+lAIWpquRciYA xCHQvMC7Qd+ijRUZkez2UtctZ9S6/th8SKbPTj/ZGKoJbOCC+u6O/UQvFBCgR5nAbISH TVdWz40fnaVIaXSFGCvZqNiefervOGniYKEr0SmaLZ72q9G0oRni14BDVvt8mwv9tWwI M4MqgyKsvuj8xpLN4bDmoV9q+0fCYbIqRqjK21n2KFbY9LknNXTRUI3SjvIgTaXGvDWR GR3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GLXTIf6sR5xPtNtzDzFOIjNOdFUZv31CNDN3CIrYk74=; b=GA6bn6xFGltEbDdMvGczUeRGTmo25QA/9H8+dXZYSemDTjUU1kSXeL6Hfz84WUGlZ4 FVyxVWrBafYnNO9gdMD4N0CHfyN0pcDWEDZijxAOnqgco22umCzHIwvdIMOJzKtaFy6s QGaZdU29xbl0d6CVT9Sh/2hzPA5+Ao5KB1Tgt+xMc9afLddye65YZlzXZQzZyJa6tWlU mi3G7/+LRlJ5uwGOut8TEhthmxkLdEdWSxhyZNPdk3e/vldQnC29R8nn2qkVgbKddvYN GiSYS1MfO4/M4qGhRen0asJ7CCGUxxV96Odfeoq065+ChKUu6c2/pUh2kyFonOCpCarw ehDQ== X-Gm-Message-State: AGi0PuZ/pnyeRffNRNyBb0sv0Oj4np9MP/heMR2nxYwD/0XmzvqnfYVo XXiR29EGim3eu8J2i3BUkCIEdyF02xHVdy4CCkJcCQ== X-Google-Smtp-Source: APiQypLl1X0WceEbqV3CCseqAkA/BN/GLFhmaw9zT23HVad8Rb4QtYfdfJzDvxOQ7nGW4agmDAH/UpYKT6hStRyKGLQ= X-Received: by 2002:a2e:9f13:: with SMTP id u19mr2242405ljk.42.1588332802396; Fri, 01 May 2020 04:33:22 -0700 (PDT) MIME-Version: 1.0 References: <20200429140341.13294-1-maco@android.com> <20200429140341.13294-2-maco@android.com> <20200429141229.GE700644@T590> In-Reply-To: <20200429141229.GE700644@T590> From: Martijn Coenen Date: Fri, 1 May 2020 13:33:11 +0200 Message-ID: Subject: Re: [PATCH v4 01/10] loop: Factor out loop size validation To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Narayan Kamath , Zimuzo Ezeozue , kernel-team@android.com, Martijn Coenen , Bart Van Assche , Chaitanya Kulkarni , Jaegeuk Kim , linux-block , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Ming, On Wed, Apr 29, 2020 at 4:12 PM Ming Lei wrote: > Now sector_t has been switched to u64 unconditionally, do we still need such > validation? I think you're right; I hadn't seen that change, but truncating because of sector_t shouldn't be an issue anymore. I wondered if we could actually have a smaller loff_t, but looks like that is 'long long', which should always be 8 bytes as well. I might send this as a separate patch, I don't want to drag this series on for too long. Thanks, Martijn > > > Thanks, > Ming > >