From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6099DC433B4 for ; Thu, 6 May 2021 12:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B801610F7 for ; Thu, 6 May 2021 12:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbhEFMwr (ORCPT ); Thu, 6 May 2021 08:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbhEFMwr (ORCPT ); Thu, 6 May 2021 08:52:47 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE4ECC061761 for ; Thu, 6 May 2021 05:51:48 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id u20so6849555lja.13 for ; Thu, 06 May 2021 05:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=leGIz44I+FDaJitpl6Hc4zICX3i8IZYPExD5nafIx0I=; b=DX3KA16LeSsMsghPZH82/XQtNlVzAV9W69bzaPNrsqbVgiv1x4Zll52FF33UWdCqmx v61tH7eAe02qtR/+yfjvmAMhlpDhREKXiZAhMUuPkwQJSKa9P5MtAeCkSK1Uc7IwONt1 odhHvegaJCLPAsU+pJvsoUUxD5HjOHNAqTwmAPunac40efQGQrqLxmVG48bEFXmE94rW oHZCKurLE6RHJ+h/+FBacZzZ1CLvgVdyhs+D3f6lLo+ggKwt5TEeF/ImX+Jm/NRK1Fko 4sNelfCaGh6qDCKy7HdaHxVn9LvJdUFQixA5BPwe9Gm0/jyPJHkg+j8Au7I2ZHcpcWKo z/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=leGIz44I+FDaJitpl6Hc4zICX3i8IZYPExD5nafIx0I=; b=a5E+bL2sMVCzXr3n7lahG2XODolseXO9tC7lw2SMd2C0yBpAzsseVmawhqjqKFrPB1 NIg9E+CQ49tUqC/ohf3FHrpaHuohjTe4EVMKsKUO/2zySEQjr6tm6S/5H2JCLC30KD65 ghMak6/aKmbgwoOwjTTWW4e4XyKxiExgwcIUDRg1Ura66eR9hHjEgE0zIxBuM4GlaahT zdD5Ig3Cvpj3Ark6GvvRcXDXVISDZjtpHIvw2YpSIZE5R6qP83xCSVSaUfBUnTIhQ+Ce a+zIBU2kIBE/5CSoQl9Za7Sxp3qTunDWApEVB2mLNzmEoFtNDyj/0waDnEwOofzo9V64 7x3A== X-Gm-Message-State: AOAM532vEPpxLWCD1UY+nii5qYEydVWxlJQn38esoyqYB+88hdFAEpf2 fQkUBaaIuhHMj+VELwHd6rlEftqOl4PfmC0IG+4Y/A== X-Google-Smtp-Source: ABdhPJwMpyg958RS71r2sEro18tQ0KNQqZLWBMMdyKHnmvXWnfmEhJ4zFsnA6TFQW0FHx+ilUWptjsL9/CwbB0ZZ0Fk= X-Received: by 2002:a2e:a54c:: with SMTP id e12mr3250389ljn.326.1620305507437; Thu, 06 May 2021 05:51:47 -0700 (PDT) MIME-Version: 1.0 References: <20210504161222.101536-1-ulf.hansson@linaro.org> <20210504161222.101536-3-ulf.hansson@linaro.org> In-Reply-To: <20210504161222.101536-3-ulf.hansson@linaro.org> From: Linus Walleij Date: Thu, 6 May 2021 14:51:35 +0200 Message-ID: Subject: Re: [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands To: Ulf Hansson Cc: linux-mmc , Adrian Hunter , Wolfram Sang , Shawn Lin , Avri Altman , Masami Hiramatsu , linux-block , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, May 4, 2021 at 6:12 PM Ulf Hansson wrote: > In mmc_send_hpi_cmd() the host->max_busy_timeout is being validated towards > the timeout for the eMMC HPI command, as to decide whether an R1 or R1B > response should be used. > > Although, it has turned out the some host can't cope with that conversion, > but needs R1B, which means MMC_CAP_NEED_RSP_BUSY is set for them. Let's > take this into account, via using the common mmc_prepare_busy_cmd() when > doing the validation, which also avoids some open coding. > > Signed-off-by: Ulf Hansson Reviewed-by: Linus Walleij Yours, Linus Walleij